gemspec and test tweaks #6

Merged
merged 2 commits into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
@kevmoo
Contributor

kevmoo commented Apr 24, 2012

No description provided.

@nathanl

This comment has been minimized.

Show comment Hide comment
@nathanl

nathanl Apr 25, 2012

Owner
  • Having rake run the tests is good.
  • I suppose Railties is the only part of Rails that we need. That will enable us to do ActionController::Base.send(:include, Authority::Controller), right?
  • Not sure about removing the requirement for Bundler.

@adamhunter - thoughts on this?

Owner

nathanl commented Apr 25, 2012

  • Having rake run the tests is good.
  • I suppose Railties is the only part of Rails that we need. That will enable us to do ActionController::Base.send(:include, Authority::Controller), right?
  • Not sure about removing the requirement for Bundler.

@adamhunter - thoughts on this?

@kevmoo

This comment has been minimized.

Show comment Hide comment
@kevmoo

kevmoo Apr 25, 2012

Contributor

Didn't see the ActionController usage. Tests don't cover it--running bundle exec rspec didn't crash which means that dependency didn't get caught.

I just removed the bundler mention, since rails depends on bundler directly.

It would be good to have a test that covers the ActionController integration

Contributor

kevmoo commented Apr 25, 2012

Didn't see the ActionController usage. Tests don't cover it--running bundle exec rspec didn't crash which means that dependency didn't get caught.

I just removed the bundler mention, since rails depends on bundler directly.

It would be good to have a test that covers the ActionController integration

@nathanl

This comment has been minimized.

Show comment Hide comment
@nathanl

nathanl Apr 25, 2012

Owner

Good points. Will add a todo to test that integration.

Owner

nathanl commented Apr 25, 2012

Good points. Will add a todo to test that integration.

nathanl added a commit that referenced this pull request Apr 25, 2012

Merge pull request #6 from kevmoo/master
gemspec and test tweaks

@nathanl nathanl merged commit fe07d80 into nathanl:master Apr 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment