Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

gemspec and test tweaks #6

Merged
merged 2 commits into from

2 participants

@kevmoo

No description provided.

@nathanl
Owner
  • Having rake run the tests is good.
  • I suppose Railties is the only part of Rails that we need. That will enable us to do ActionController::Base.send(:include, Authority::Controller), right?
  • Not sure about removing the requirement for Bundler.

@adamhunter - thoughts on this?

@kevmoo

Didn't see the ActionController usage. Tests don't cover it--running bundle exec rspec didn't crash which means that dependency didn't get caught.

I just removed the bundler mention, since rails depends on bundler directly.

It would be good to have a test that covers the ActionController integration

@nathanl
Owner

Good points. Will add a todo to test that integration.

@nathanl nathanl merged commit fe07d80 into nathanl:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −0 Rakefile
  2. +0 −1  authority.gemspec
View
5 Rakefile
@@ -1,2 +1,7 @@
#!/usr/bin/env rake
require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task "default" => "spec"
View
1  authority.gemspec
@@ -9,7 +9,6 @@ Gem::Specification.new do |gem|
gem.homepage = "https://github.com/nathanl/authority"
gem.add_dependency "rails", ">= 3.0.0"
- gem.add_development_dependency "bundler", ">= 1.0.0"
gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
gem.files = `git ls-files`.split("\n")
Something went wrong with that request. Please try again.