Fix for #39. #40

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
7 participants
@xpe
Contributor

xpe commented Jul 24, 2013

I think that the upgrade from jClouds 1.4.2 to 1.5.1 in the previous
commit (9d6e47b) made a change in how .createSecurityGroupInRegion
works (see security.clj).

Likely fix for #39.
I think that the upgrade from jClouds 1.4.2 to 1.5.1 in the previous
commit (9d6e47b) made a change in how `.createSecurityGroupInRegion`
works (see security.clj).
@pherris

This comment has been minimized.

Show comment
Hide comment
@pherris

pherris Jul 24, 2013

This fixed the issue for me, thanks!

This fixed the issue for me, thanks!

This comment has been minimized.

Show comment
Hide comment
@gworley3

gworley3 Jul 24, 2013

I have made essentially the same change in our fork of the project. Sorry for not pushing it back, but I can confirm that this works.

I have made essentially the same change in our fork of the project. Sorry for not pushing it back, but I can confirm that this works.

@lorcan

This comment has been minimized.

Show comment
Hide comment
@lorcan

lorcan Aug 28, 2013

Contributor

This also fixed the issue for me. Thanks :-)
Can we get this request pulled in?

Contributor

lorcan commented Aug 28, 2013

This also fixed the issue for me. Thanks :-)
Can we get this request pulled in?

@msegel

This comment has been minimized.

Show comment
Hide comment
@msegel

msegel Oct 1, 2013

Hi, ran in to the same problem... found the fix in lorcan's branch (which looks like xpe found first)...
What does it take to get it implemented in the main branch?

Looks like it was fixed 2 months ago?

Thx

msegel commented Oct 1, 2013

Hi, ran in to the same problem... found the fix in lorcan's branch (which looks like xpe found first)...
What does it take to get it implemented in the main branch?

Looks like it was fixed 2 months ago?

Thx

@64BitChris

This comment has been minimized.

Show comment
Hide comment
@64BitChris

64BitChris Oct 22, 2013

Can we please merge this in? As it stands, the master branch is unusable without this fix. I had to merge in @lorcan 's fix to get this to work.

Can we please merge this in? As it stands, the master branch is unusable without this fix. I had to merge in @lorcan 's fix to get this to work.

tbatchelli added a commit that referenced this pull request Oct 23, 2013

@tbatchelli tbatchelli merged commit 371d290 into nathanmarz:master Oct 23, 2013

@64BitChris

This comment has been minimized.

Show comment
Hide comment
@64BitChris

64BitChris Oct 23, 2013

Thanks so much!!

Thanks so much!!

@xpe

This comment has been minimized.

Show comment
Hide comment
@xpe

xpe Oct 23, 2013

Contributor

@tbatchelli Thank you!

Contributor

xpe commented Oct 23, 2013

@tbatchelli Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment