Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allows storm-deploy more flexibility - checkout branches and SHA1s #45
gets you storm 0.9.0wip16 (roughly, actually it gets you commit (d12c33543c9b2e8c8e35908f8672fa06edd18c2e, which is between 0.9.0-wip16 and 0.9.0-wip17)
gets you the latest commit from master. It's not possible to get anything inbetween.
This commit drops the
If you want the latest version from a specific branch (say 0.8.3) you can execute
and if you want the bleeding edge you can still execute this get the latest commit from master
The diff on this commit is bigger than it might have been because i deliberately changed
I'd love to get feedback on this. I've played around with it today but I wouldn't go so far to say it's perfect. I'd like to see if anyone else has had success with it before pulling it into nathanmarz/storm-deploy proper.
added a commit
this pull request
Oct 23, 2013
referenced this pull request
Nov 1, 2013
What do you have in mind? The SHA1 commits are listed on each release and indeed on every code listing. I think there is a bigger issue here and that is that most users will never want to checkout by SHA1 commits - they would likely prefer to use tagged releases (which are a recent addition to storm) - see #46.
Well the sha1 hash isn't really human readable or memorable.
I mean I can remember 0.9.0-wipX or 0.9.0-rc2 but a 128bit string of randomness?
Completely agree, no human should have to deal with SHA1s :-) Check out the updated documentation. Tagged releases are discussed, you can checkout a tagged release of storm as follows:
Users should be allowed to check out by SHA1 but generally I doubt many people will use that as the preferred option - more likely people will want tagged releases, or latest commits on particular branches...
That's what is needed!