Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

the sass file could use some variable goodness #49

Open
chrisdrackett opened this Issue · 9 comments

4 participants

@chrisdrackett

being sass and all

@nathansmith
Owner

What aspects would you like to see variable-ized?

@chrisdrackett

I just saw a lot of repeated colors and sizes. Seems if you are going to use sass, might be worth creating maybe a mixin so users can customize the colors/sizes by changing a couple of clear variables

@nathansmith
Owner

Yeah, not disagreeing, was just wondering if you had specifics you'd like to see variable-ized. Cool, cool.

@chrisdrackett

yeah, sorry ;)

I actually wrote this issue and was planning on doing it myself. Then I decided that formalize has a bit too many default styles for my use, and I've started writing my own "reset" that in theory will be theme-able.

@nathansmith
Owner

This might be of interest...

https://gist.github.com/1599212

It removes all styling of form elements, so that they can be built back up again.

@chrisdrackett

nice, thanks :)

@chrisvanpatten

I'd love to see Formalize variablized too. It would make it easy to deploy customized versions.

@henrijs

For me main issue is padding of form elements. This line in particular is evil "height: 1.8em;" If I add 3 pixels of padding above and below, by how much should I increase height? (Rethorical question). Sass could calculate that probably.

Also font-family could be as one mixin.

@nathansmith
Owner

@henrijs — Sure, that could be automated (made dependent on a variable), but not reliably calculated. I mean, it's going to be contingent on whatever visual effect you're trying to achieve. I settled on 1.8em because that makes textual inputs the same height as a <select> drop-down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.