Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Tablet media query #16

Closed
tylkomat opened this Issue Apr 2, 2013 · 4 comments

Comments

Projects
None yet
2 participants

tylkomat commented Apr 2, 2013

Since this is a 960px grid, shouldn't a tablet with 1024 resolution in landscape be able to display the desktop view?

In my opinion the rule: @media screen and (min-width: 767px) and (max-width: 1026px) { should be @media screen and (min-width: 767px) and (max-width: 980px) {

What do you think ?

Owner

nathansmith commented Apr 2, 2013

I get what you're saying, but:


  1. This isn't a 960px grid. It is fluid.
  2. There are actually separate files for "tablet specific media query" and "tablet acts as desktop."

Mobile, Tablet, Desktop media queries…

https://github.com/nathansmith/unsemantic/blob/master/assets/sass/partials/_unsemantic-grid-responsive-tablet.sass

Mobile, Desktop media queries…

https://github.com/nathansmith/unsemantic/blob/master/assets/sass/partials/_unsemantic-grid-responsive.sass


I think that covers the use-case you're talking about. Just use the CSS without -tablet in the name…

https://github.com/nathansmith/unsemantic/blob/master/assets/stylesheets/unsemantic-grid-responsive.css

tylkomat commented Apr 2, 2013

In my use case I still like to have 3 different settings (mobile, tablet and desktop). I already edited it on my local copy anyway, but I was thinking that it might be useful for others too.

If I use the tablet in portrait position the tablet mode should be active, because 768px is quite small, but if I use it in landscape position there is enough space to fit everything. Many small notebooks also just have 1024x768 resolution. That's what I was referring to.

Owner

nathansmith commented Apr 2, 2013

Ah, gotcha.

Sorry, I think I just didn't grasp what you were saying before.

Yeah, I think that makes sense.

I'm hesitant to change that as the default though, since it's already been "in the wild" for awhile, and I don't want to break anything where people are relying on a 1024/1025 breakpoint.

tylkomat commented Apr 3, 2013

Yes I understand that. Maybe you can just compile another css and see how the feedback is. Anyway your framework is great. I tried others which didn't achieve what I needed. Accept this change that I did and discussed here, yours worked out best 👍

@tylkomat tylkomat closed this Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment