Added custom error reporting around JSON parsing of comet messages, j…

…ust in case this didn't solve it. It will post relevant info to a server action that emails admin and nathan.
nathansobo · Dec 14, 2010 · f3d06d7 · f3d06d7
1 parent bfe9a7f
commit f3d06d7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/monarch/http/comet_client.js b/lib/monarch/http/comet_client.js
@@ -27,9 +27,23 @@ _.constructor("Monarch.Http.CometClient", {
           numReceivedCharacters += unreadLines.length;
           unreadLines = _.trim(unreadLines);
           if (unreadLines.length === 0) return;
-
           _.each(unreadLines.split("\n"), function(messageString) {
-            var message = JSON.parse(messageString);
+
+            try {
+              var message = JSON.parse(messageString);
+            } catch(e) {
+              // Special error handling added 12/14/10 -- Remove if we haven't seen any issues in a while
+              var errorReport = "In comet client, while attempting to parse the following JSON string:\n" +
+                messageString + "\n\n" +
+                e.stack;
+
+              if (window.console) {
+                console.debug("ERROR: " + errorReport);
+              }
+
+              Server.post("/client_error", {error: errorReport });
+            }
+
             if (message[0] == "connected") {
               connectFuture.triggerSuccess();
             } else {

diff --git a/vendor/underscore.js b/vendor/underscore.js
@@ -74,7 +74,9 @@
         }
       }
     } catch(e) {
-      if (e != breaker) throw e;
+      if (e != breaker) {
+        throw e;
+      }
     }
     return obj;
   };