Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N3GOV-26 #32

Merged
merged 3 commits into from Dec 20, 2022
Merged

N3GOV-26 #32

merged 3 commits into from Dec 20, 2022

Conversation

luisivan
Copy link
Contributor

No description provided.

aahna-ashina
aahna-ashina reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the file from -X to -26?

@luisivan
Copy link
Contributor Author

luisivan commented Dec 14, 2022 •
edited

Technically the governance process states it should be N3GOV-X.json, but it doesn't specify whether the X is a placeholder to leave until a reviewer assigns a number, or the actual self-assigned number 😆 Anyway, I moved the file

@aahna-ashina
Copy link
Member

@luisivan Got it. Maybe some of these steps can be automated also (to avoid human error).

@luisivan
Copy link
Contributor Author

@aahna-ashina would love to automate this workflow. Ideally a bot checks the payload against the spec and automatically merges if the forum post has been out more than 48h

@luisivan luisivan merged commit ac4165b into main Dec 20, 2022
@luisivan luisivan deleted the N3GOV-26 branch December 20, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aahna-ashina aahna-ashina aahna-ashina left review comments

@anastasiyabelyaeva anastasiyabelyaeva Awaiting requested review from anastasiyabelyaeva

@xPi2 xPi2 Awaiting requested review from xPi2

@RayomndC RayomndC Awaiting requested review from RayomndC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luisivan @aahna-ashina