This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Restore application window on notification click #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@sissbruecker makes sense, thanks! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently is an issue where the nativefied application does not respond to clicking on a desktop notification. You would expect it to restore and focus its window, but that doesn't work if:
See #221 and possibly #396.
This PR fixes that by adding a click handler to each notification. When clicking the notification the Electron app restores and focuses the main window using BrowserWindow.show(). This seems to handle both cases (restore minimized window / open new window, then focus window).