New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random debugging information being printed #328

Closed
jonhare opened this Issue Jul 12, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@jonhare

jonhare commented Jul 12, 2012

Both the native and java code contain a number of printf/println statements which were obviously designed for debugging. This is somewhat annoying when writing a command line program that uses Bridj as the output from Bridj gets mixed in with the output from the program.

It would be much better if Bridj used some kind of logging framework, or at least provided a way to turn off its output.

@ochafik

This comment has been minimized.

Show comment
Hide comment
@ochafik

ochafik Jul 12, 2012

Member

Hi @jonhare ,

Thanks for the excellent suggestion, it's high time the logging is rationalized indeed!

Cheers

Member

ochafik commented Jul 12, 2012

Hi @jonhare ,

Thanks for the excellent suggestion, it's high time the logging is rationalized indeed!

Cheers

@sarxos

This comment has been minimized.

Show comment
Hide comment
@sarxos

sarxos Jul 12, 2012

Contributor

+1

Contributor

sarxos commented Jul 12, 2012

+1

@ochafik

This comment has been minimized.

Show comment
Hide comment
@ochafik

ochafik Jul 17, 2012

Member

Hi @jonhare ,

I've started making logs less noisy + added a BRIDJ_QUIET=1 / -Dbridj.quiet=true switch to turn them off completely.
There's still one printf error log from native code for dlopen / LoadLibrary errors, but it shouldn't happen in normal circumstances and I'll try to remove it soon anyway.
Please let me know if you still see any parasite logs in the latest 0.6.2-SNAPSHOT or need further customization :-)

Cheers

Member

ochafik commented Jul 17, 2012

Hi @jonhare ,

I've started making logs less noisy + added a BRIDJ_QUIET=1 / -Dbridj.quiet=true switch to turn them off completely.
There's still one printf error log from native code for dlopen / LoadLibrary errors, but it shouldn't happen in normal circumstances and I'll try to remove it soon anyway.
Please let me know if you still see any parasite logs in the latest 0.6.2-SNAPSHOT or need further customization :-)

Cheers

@ochafik

This comment has been minimized.

Show comment
Hide comment
@ochafik

ochafik Jul 17, 2012

Member

(oh, and all logs now go through java.util.logging.Logger, so it should be possible to add file-based configuration and other regular logging magics / filters)

Member

ochafik commented Jul 17, 2012

(oh, and all logs now go through java.util.logging.Logger, so it should be possible to add file-based configuration and other regular logging magics / filters)

@sarxos

This comment has been minimized.

Show comment
Hide comment
@sarxos

sarxos Jan 11, 2013

Contributor

Hi,

There is a code in Demangler class which prints some info to stderr:

if (totalArgs != parameterTypes.length) {
  System.err.println("Not enough args for " + this);
  return false;
}

Is it possible to enhance it to support -Dbridj.quiet=true property, and/or pass it to log LOG.error("message here") ??

Contributor

sarxos commented Jan 11, 2013

Hi,

There is a code in Demangler class which prints some info to stderr:

if (totalArgs != parameterTypes.length) {
  System.err.println("Not enough args for " + this);
  return false;
}

Is it possible to enhance it to support -Dbridj.quiet=true property, and/or pass it to log LOG.error("message here") ??

@ochafik

This comment has been minimized.

Show comment
Hide comment
@ochafik

ochafik Jun 9, 2013

Member

Closing now, please let me know if it needs to be reopened

Member

ochafik commented Jun 9, 2013

Closing now, please let me know if it needs to be reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment