Skip to content

fix(android): onCharacteristicRead deprecated #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023
Merged

fix(android): onCharacteristicRead deprecated #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ble/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,12 +767,17 @@ function initBluetoothGattCallback() {
* Callback reporting the result of a characteristic read operation.
* @param gatt [android.bluetooth.BluetoothGatt] - GATT client invoked readCharacteristic(BluetoothGattCharacteristic)
* @param characteristic - Characteristic that was read from the associated remote device.
* @params value - byte: the value of the characteristic This value cannot be null. This will "status" in Android API level < 33.
* @param status [number] - GATT_SUCCESS if the read operation was completed successfully.
*/
onCharacteristicRead(gatt: android.bluetooth.BluetoothGatt, characteristic: android.bluetooth.BluetoothGattCharacteristic, status: number) {
onCharacteristicRead(gatt: android.bluetooth.BluetoothGatt, characteristic: android.bluetooth.BluetoothGattCharacteristic, value : any, status: number) {
this.subDelegates.forEach((d) => {
if (d.onCharacteristicRead) {
d.onCharacteristicRead(gatt, characteristic, status);
if (sdkVersion < 33) {
d.onCharacteristicRead(gatt, characteristic, value);
} else {
d.onCharacteristicRead(gatt, characteristic, status);
}
}
});
}
Expand Down