Skip to content

Allow locally installed tns to be used by plugin #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2020
Merged

Allow locally installed tns to be used by plugin #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db4015
Allow locally installed tns to be used by plugin
Logikgate Jun 3, 2019
b83a78d
Fix tslint errors
Logikgate Feb 13, 2020
67e8358
Merge branch 'master' into master
Logikgate Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { services } from './services/extensionHostServices';
// this method is called when the extension is activated
export function activate(context: vscode.ExtensionContext) {
services.globalState = context.globalState;
services.cliPath = services.workspaceConfigService.tnsPath || services.cliPath;
services.cliPath = 'tns';

const channel = vscode.window.createOutputChannel('NativeScript Extension');

Expand Down
5 changes: 4 additions & 1 deletion src/services/buildService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ export class BuildService {

public async processRequest(args: any): Promise<any> {
const tnsPath = services.workspaceConfigService.tnsPath;
const cli = new NativeScriptCli(tnsPath, this._logger);

this._logger.log(`[NSDebugAdapter] Using tns CLI on path '${tnsPath}'\n`);
const tnsPathResolved = (tnsPath !== 'tns' && !path.isAbsolute(tnsPath)) ? path.join(args.appRoot, tnsPath) : tnsPath;
const cli = new NativeScriptCli(tnsPathResolved, this._logger);

const project = args.platform === 'ios' ?
new IosProject(args.appRoot, cli) :
Expand Down