Skip to content

fix: cache #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farfromrefug merged 1 commit into from
Dec 2, 2025
Merged

fix: cache #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/image/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ export function initialize(config?: ImagePipelineConfigSetting): void {

// this is needed for further buildKey to trigger ...
com.bumptech.glide.Glide.with(context)
.load('toto?ts=' + Date().valueOf())
.apply(new com.bumptech.glide.request.RequestOptions().signature(new com.bumptech.glide.signature.ObjectKey(Date().valueOf())))
.load('toto')
.apply(new com.bumptech.glide.request.RequestOptions().signature(signature))
.preload();
// com.nativescript.image.EngineKeyFactoryMethodDumper.dumpKeyFactoryMethods(glideInstance);
// com.nativescript.image.ForcePreloadTest.forcePreloadAfterInjection(context, 'https://example.com/test-image.png');
Expand Down Expand Up @@ -235,7 +235,10 @@ export class ImagePipeline {
try {
const context = Utils.android.getApplicationContext();
const requestManager = com.bumptech.glide.Glide.with(context);
const requestBuilder = requestManager.asBitmap().load(uri);
const requestBuilder = requestManager
.asBitmap()
.load(uri)
.apply(new com.bumptech.glide.request.RequestOptions().signature(signature));

let futureTarget = null;
function clearLater() {
Expand Down Expand Up @@ -272,7 +275,9 @@ export class ImagePipeline {
try {
const context = Utils.android.getApplicationContext();
const requestManager = com.bumptech.glide.Glide.with(context);
const requestBuilder = toDiskCache ? requestManager.downloadOnly().load(uri) : requestManager.asBitmap().load(uri);
const requestBuilder = (toDiskCache ? requestManager.downloadOnly().load(uri) : requestManager.asBitmap().load(uri)).apply(
new com.bumptech.glide.request.RequestOptions().signature(signature)
);

let futureTarget = null;
function clearLater() {
Expand Down Expand Up @@ -636,7 +641,7 @@ export class Img extends ImageBase {
this.loadSourceCallback // Can be null
);
}
requestBuilder = com.bumptech.glide.Glide.with(context).load(loadModel).signature(new com.bumptech.glide.signature.ObjectKey(Date().valueOf()));
requestBuilder = com.bumptech.glide.Glide.with(context).load(loadModel);

// Apply transformations (blur, rounded corners, etc.)
const transformations = [];
Expand Down Expand Up @@ -817,7 +822,10 @@ export class Img extends ImageBase {
target.setClearFirst(false);
}

requestBuilder.signature(signature).listener(new com.nativescript.image.CompositeRequestListener(objectArr)).into(target);
requestBuilder
.apply(ro)
.listener(new com.nativescript.image.CompositeRequestListener(objectArr))
.into(target);
}

private notifyLoadSource(source: string) {
Expand Down