Skip to content

fix(tracking user): tracking the user was not implemented on iOS #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix(tracking user): tracking the user was not implemented on iOS #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 16 additions & 30 deletions src/ui-mapbox/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,21 +581,6 @@ const _getMapStyle = (input: any): NSURL => {
}
};

function _getTrackingMode(input: UserLocationCameraMode): MGLUserTrackingMode {
/*
if (input === "FOLLOW") {
return MGLUserTrackingMode.Follow;
} else if (input === "FOLLOW_WITH_HEADING") {
return MGLUserTrackingMode.FollowWithHeading;
} else if (input === "FOLLOW_WITH_COURSE") {
return MGLUserTrackingMode.FollowWithCourse;
} else {
return MGLUserTrackingMode.None;
}
*/
return MGLUserTrackingMode.None;
}

function _getLocation(loc: MGLUserLocation) {
if (loc === null) {
return null;
Expand Down Expand Up @@ -1775,35 +1760,36 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
* @todo come up with a reasonable set of cross platform defaults.
*/
_stringToCameraMode(mode: UserLocationCameraMode): any {
switch (mode) {
case 'NONE':
switch(mode) {
case "NONE":
return MGLUserTrackingMode.None;

case 'NONE_COMPASS':
if (Trace.isEnabled()) {
CLog(CLogTypes.info, '_stringToCameraMode(): NONE_COMPASS unsupported on iOS');
}
case "NONE_COMPASS":
console.log("MapboxView::_stringToCameraMode(): NONE_COMPASS unsupported on iOS");
return MGLUserTrackingMode.None;

case 'NONE_GPS':
if (Trace.isEnabled()) {
CLog(CLogTypes.info, '_stringToCameraMode(): NONE_GPS unsupported on iOS');
}
case "NONE_GPS":
console.log("MapboxView::_stringToCameraMode(): NONE_GPS unsupported on iOS");
return MGLUserTrackingMode.None;

case 'TRACKING':
case "TRACKING":
return MGLUserTrackingMode.Follow;

case 'TRACKING_COMPASS':
case "TRACKING_COMPASS":
return MGLUserTrackingMode.FollowWithHeading;

case 'TRACKING_GPS':
case "TRACKING_GPS":
// a reasonable approximation.
return MGLUserTrackingMode.Follow;

case 'TRACKING_GPS_NORTH':
case "TRACKING_GPS_NORTH":
return MGLUserTrackingMode.FollowWithCourse;

default:
console.log(`_stringToCameraMode: invalid cameraMode: ${mode}`);
}

return MGLUserTrackingMode.None;
}

_stringToRenderMode(mode): any {
Expand Down Expand Up @@ -3095,7 +3081,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
return;
}

theMap.setUserTrackingModeAnimated(_getTrackingMode(options.cameraMode), options.animated !== false);
theMap.setUserTrackingModeAnimated(this._stringToCameraMode(options.cameraMode), options.animated !== false);

resolve();
} catch (ex) {
Expand Down