From 9cea2479592d0f489b3648999168633fee43b690 Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Thu, 24 Oct 2019 23:50:46 -0700
Subject: [PATCH 1/7] Extract tag modal and script to include, update blacklist
 route.

---
 natlas-server/app/admin/routes.py             |  2 +
 .../app/templates/admin/_tagmodal.html        | 60 ++++++++++++++++++
 .../app/templates/admin/blacklist.html        |  2 +-
 natlas-server/app/templates/admin/scope.html  | 61 +------------------
 4 files changed, 64 insertions(+), 61 deletions(-)
 create mode 100644 natlas-server/app/templates/admin/_tagmodal.html

diff --git a/natlas-server/app/admin/routes.py b/natlas-server/app/admin/routes.py
index 0f4cf5db..8ead94aa 100644
--- a/natlas-server/app/admin/routes.py
+++ b/natlas-server/app/admin/routes.py
@@ -135,6 +135,8 @@ def blacklist():
 	delForm = ScopeDeleteForm()
 	editForm = ScopeToggleForm()
 	importForm = ImportBlacklistForm()
+	addTagForm = TagScopeForm()
+	addTagForm.tagname.choices = [(row.name, row.name) for row in Tag.query.all()]
 	if newForm.validate_on_submit():
 		if '/' not in newForm.target.data:
 			newForm.target.data = newForm.target.data + '/32'
diff --git a/natlas-server/app/templates/admin/_tagmodal.html b/natlas-server/app/templates/admin/_tagmodal.html
new file mode 100644
index 00000000..1dbc9773
--- /dev/null
+++ b/natlas-server/app/templates/admin/_tagmodal.html
@@ -0,0 +1,60 @@
+<div class="modal fade" tabindex="-1" role="dialog" id="tagmodal">
+  <div class="modal-dialog" role="document">
+    <div class="modal-content">
+      <div class="modal-header">
+        <h5 class="modal-title">Add Tag</h5>
+        <button type="button" class="close" data-dismiss="modal" aria-label="Close">
+          <span aria-hidden="true">&times;</span>
+        </button>
+      </div>
+      <form method="POST" action="{{url_for('admin.scope')}}" id="tagScopeForm">
+        <div class="modal-body">
+            {{ addTagForm.hidden_tag() }}
+            {{ addTagForm.tagname(class="custom-select") }}
+        </div>
+        <div class="modal-footer">
+          <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
+          <button type="submit" id="tagScopeSubmit" class="btn btn-primary">Add Tag</button>
+        </div>
+      </form>
+    </div>
+  </div>
+</div>
+<script>
+$('#tagmodal').on('show.bs.modal', function (event) {
+  var button = $(event.relatedTarget) // Button that triggered the modal
+  var scopeid = button.data('scopeid') // Extract info from data-* attributes
+  var scopetarget = button.data('scopetarget') // Extract info from data-* attributes
+  var tagaction = button.data('action')
+  var tagstr = $('#scopeTags-'+scopeid).text().replace(/\s+/g,'')
+  var tags = tagstr.split(',')
+  var modal = $(this)
+  if (tagaction == 'add') {
+    modal.find('.modal-title').text('Add tag to ' + scopetarget)
+    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/tag")
+    modal.find('#tagScopeSubmit').text('Add Tag')
+    if (tagstr != ''){
+      tags.forEach(function(item) {
+        $("option[value="+item+"]").attr('hidden', '')
+        $("option[value="+item+"]").attr('disabled', '')
+      });
+    }
+
+
+  } else {
+    modal.find('.modal-title').text('Remove tag from ' + scopetarget)
+    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/untag")
+    modal.find('#tagScopeSubmit').text('Remove Tag')
+    $("select[name='tagname']")[0].options.length = 0;
+    
+    tags.forEach(function(item) {
+      $("#tagname").append(
+        $('<option>', {
+          value: item,
+          text: item
+        })
+      );
+    });
+  }
+})
+</script>
\ No newline at end of file
diff --git a/natlas-server/app/templates/admin/blacklist.html b/natlas-server/app/templates/admin/blacklist.html
index 203996f0..71cc26db 100644
--- a/natlas-server/app/templates/admin/blacklist.html
+++ b/natlas-server/app/templates/admin/blacklist.html
@@ -57,5 +57,5 @@ <h3>Import Blacklist</h3>
       </form>
     </div>
   </div>
-    
+{% include 'admin/_tagmodal.html' %}
 {% endblock %}
\ No newline at end of file
diff --git a/natlas-server/app/templates/admin/scope.html b/natlas-server/app/templates/admin/scope.html
index d8d554dd..bc7da5ae 100644
--- a/natlas-server/app/templates/admin/scope.html
+++ b/natlas-server/app/templates/admin/scope.html
@@ -62,64 +62,5 @@ <h3>Import Scope</h3>
     </div>
   </div>
 
-<div class="modal fade" tabindex="-1" role="dialog" id="tagmodal">
-  <div class="modal-dialog" role="document">
-    <div class="modal-content">
-      <div class="modal-header">
-        <h5 class="modal-title">Add Tag</h5>
-        <button type="button" class="close" data-dismiss="modal" aria-label="Close">
-          <span aria-hidden="true">&times;</span>
-        </button>
-      </div>
-      <form method="POST" action="{{url_for('admin.scope')}}" id="tagScopeForm">
-        <div class="modal-body">
-            {{ addTagForm.hidden_tag() }}
-            {{ addTagForm.tagname(class="custom-select") }}
-        </div>
-        <div class="modal-footer">
-          <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
-          <button type="submit" id="tagScopeSubmit" class="btn btn-primary">Add Tag</button>
-        </div>
-      </form>
-    </div>
-  </div>
-</div>
-<script>
-$('#tagmodal').on('show.bs.modal', function (event) {
-  var button = $(event.relatedTarget) // Button that triggered the modal
-  var scopeid = button.data('scopeid') // Extract info from data-* attributes
-  var scopetarget = button.data('scopetarget') // Extract info from data-* attributes
-  var tagaction = button.data('action')
-  var tagstr = $('#scopeTags-'+scopeid).text().replace(/\s+/g,'')
-  var tags = tagstr.split(',')
-  var modal = $(this)
-  if (tagaction == 'add') {
-    modal.find('.modal-title').text('Add tag to ' + scopetarget)
-    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/tag")
-    modal.find('#tagScopeSubmit').text('Add Tag')
-    if (tagstr != ''){
-      tags.forEach(function(item) {
-        $("option[value="+item+"]").attr('hidden', '')
-        $("option[value="+item+"]").attr('disabled', '')
-      });
-    }
-
-
-  } else {
-    modal.find('.modal-title').text('Remove tag from ' + scopetarget)
-    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/untag")
-    modal.find('#tagScopeSubmit').text('Remove Tag')
-    $("select[name='tagname']")[0].options.length = 0;
-    
-    tags.forEach(function(item) {
-      $("#tagname").append(
-        $('<option>', {
-          value: item,
-          text: item
-        })
-      );
-    });
-  }
-})
-</script>
+{% include 'admin/_tagmodal.html' %}
 {% endblock %}
\ No newline at end of file

From 105ed2dcb0347a7f11c439d46ac5a01e4f871ceb Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Wed, 30 Oct 2019 22:05:24 -0700
Subject: [PATCH 2/7] Improve tagging consistency.

Fixes #206, makes scope tagging available on both scope and blacklist pages. Tried to make some code cleanup while I was at it, as well as improve other inconsistencies with tags.
---
 natlas-server/app/admin/routes.py             |  6 ++-
 natlas-server/app/models.py                   |  2 +-
 natlas-server/app/static/js/natlas-tagging.js | 36 +++++++++++++++++
 .../app/templates/admin/_tagmodal.html        | 39 +------------------
 .../app/templates/admin/blacklist.html        |  2 +-
 natlas-server/app/templates/admin/scope.html  |  6 +--
 6 files changed, 44 insertions(+), 47 deletions(-)
 create mode 100644 natlas-server/app/static/js/natlas-tagging.js

diff --git a/natlas-server/app/admin/routes.py b/natlas-server/app/admin/routes.py
index 8ead94aa..ffacdca1 100644
--- a/natlas-server/app/admin/routes.py
+++ b/natlas-server/app/admin/routes.py
@@ -147,7 +147,8 @@ def blacklist():
 		current_app.ScopeManager.update()
 		flash('%s blacklisted!' % newTarget.target, 'success')
 		return redirect(url_for('admin.blacklist'))
-	return render_template("admin/blacklist.html", scope=scope, blacklistSize=blacklistSize, delForm=delForm, editForm=editForm, newForm=newForm, importForm=importForm)
+	return render_template("admin/blacklist.html", scope=scope, blacklistSize=blacklistSize, delForm=delForm, editForm=editForm, \
+		newForm=newForm, importForm=importForm, addTagForm=addTagForm)
 
 
 
@@ -427,7 +428,8 @@ def tags():
 
 	addForm = AddTagForm()
 	if addForm.validate_on_submit():
-		newTag = Tag(name=addForm.tagname.data.lower())
+		prepared_tag = addForm.tagname.data.strip()
+		newTag = Tag(name=prepared_tag)
 		db.session.add(newTag)
 		db.session.commit()
 		flash('Successfully added tag %s' % newTag.name, 'success')
diff --git a/natlas-server/app/models.py b/natlas-server/app/models.py
index 1edd87cf..570759ff 100644
--- a/natlas-server/app/models.py
+++ b/natlas-server/app/models.py
@@ -121,7 +121,7 @@ def addTags(scopeitem, tags):
 			if existingTag:
 				scopeitem.addTag(existingTag)
 			else:
-				newTag = Tag(name=tag)
+				newTag = Tag(name=tag.strip())
 				db.session.add(newTag)
 				scopeitem.addTag(newTag)
 
diff --git a/natlas-server/app/static/js/natlas-tagging.js b/natlas-server/app/static/js/natlas-tagging.js
new file mode 100644
index 00000000..34b01482
--- /dev/null
+++ b/natlas-server/app/static/js/natlas-tagging.js
@@ -0,0 +1,36 @@
+$('#tagmodal').on('show.bs.modal', function (event) {
+  var button = $(event.relatedTarget) // Button that triggered the modal
+  var scopeid = button.data('scopeid') // Extract info from data-* attributes
+  var scopetarget = button.data('scopetarget') // Extract info from data-* attributes
+  var tagaction = button.data('action')
+  var tagstr = $('#scopeTags-'+scopeid).text().trim() // Trim whitespace in jinja formatting leaves whitespace
+  var tags = tagstr.split(', ')
+  var modal = $(this)
+  if (tagaction == 'add') {
+    modal.find('.modal-title').text('Add tag to ' + scopetarget)
+    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/tag")
+    modal.find('#tagScopeSubmit').text('Add Tag')
+    if (tagstr != ''){
+      tags.forEach(function(item) {
+        $("option[value=" + item.trim() + "]").attr('hidden', '') // hide this option because it's already added
+        $("option[value=" + item.trim() + "]").attr('disabled', '') // disable this option because it's hidden
+      });
+    }
+
+
+  } else {
+    modal.find('.modal-title').text('Remove tag from ' + scopetarget)
+    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/untag")
+    modal.find('#tagScopeSubmit').text('Remove Tag')
+    $("select[name='tagname']")[0].options.length = 0;
+
+    tags.forEach(function(item) {
+      $("#tagname").append(
+        $('<option>', {
+          value: item.trim(),
+          text: item.trim()
+        })
+      );
+    });
+  }
+})
\ No newline at end of file
diff --git a/natlas-server/app/templates/admin/_tagmodal.html b/natlas-server/app/templates/admin/_tagmodal.html
index 1dbc9773..19af69ea 100644
--- a/natlas-server/app/templates/admin/_tagmodal.html
+++ b/natlas-server/app/templates/admin/_tagmodal.html
@@ -20,41 +20,4 @@ <h5 class="modal-title">Add Tag</h5>
     </div>
   </div>
 </div>
-<script>
-$('#tagmodal').on('show.bs.modal', function (event) {
-  var button = $(event.relatedTarget) // Button that triggered the modal
-  var scopeid = button.data('scopeid') // Extract info from data-* attributes
-  var scopetarget = button.data('scopetarget') // Extract info from data-* attributes
-  var tagaction = button.data('action')
-  var tagstr = $('#scopeTags-'+scopeid).text().replace(/\s+/g,'')
-  var tags = tagstr.split(',')
-  var modal = $(this)
-  if (tagaction == 'add') {
-    modal.find('.modal-title').text('Add tag to ' + scopetarget)
-    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/tag")
-    modal.find('#tagScopeSubmit').text('Add Tag')
-    if (tagstr != ''){
-      tags.forEach(function(item) {
-        $("option[value="+item+"]").attr('hidden', '')
-        $("option[value="+item+"]").attr('disabled', '')
-      });
-    }
-
-
-  } else {
-    modal.find('.modal-title').text('Remove tag from ' + scopetarget)
-    modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/untag")
-    modal.find('#tagScopeSubmit').text('Remove Tag')
-    $("select[name='tagname']")[0].options.length = 0;
-    
-    tags.forEach(function(item) {
-      $("#tagname").append(
-        $('<option>', {
-          value: item,
-          text: item
-        })
-      );
-    });
-  }
-})
-</script>
\ No newline at end of file
+<script src="/static/js/natlas-tagging.js"></script>
\ No newline at end of file
diff --git a/natlas-server/app/templates/admin/blacklist.html b/natlas-server/app/templates/admin/blacklist.html
index 71cc26db..32448aa7 100644
--- a/natlas-server/app/templates/admin/blacklist.html
+++ b/natlas-server/app/templates/admin/blacklist.html
@@ -35,7 +35,7 @@ <h3 class="mt-3">Manage Blacklist ({{ blacklistSize }} hosts)</h3>
           <tr>
             <th scope="row">{{ item.id }}</th>
             <td>{{ item.target }}</td>
-            <td>{% for tag in item.tags %}{{ tag.name }}{% if not loop.last %}, {% endif %}{% endfor %}</td>
+            <td id="scopeTags-{{item.id}}">{% for tag in item.tags %}{{ tag.name }}{% if not loop.last %}, {% endif %}{% endfor %}</td>
             <td style="text-align:center;">
               {% include 'admin/_scope_menu.html' %}
             </td>
diff --git a/natlas-server/app/templates/admin/scope.html b/natlas-server/app/templates/admin/scope.html
index bc7da5ae..35f912b7 100644
--- a/natlas-server/app/templates/admin/scope.html
+++ b/natlas-server/app/templates/admin/scope.html
@@ -35,11 +35,7 @@ <h3 class="mt-3">Manage Scope ({{ scopeSize }} hosts)</h3>
           <tr>
             <th scope="row">{{ item.id }}</th>
             <td>{{ item.target }}</td>
-            <td id="scopeTags-{{item.id}}">
-              {% for tag in item.tags %}
-              {{ tag.name }}{% if not loop.last %}, {% endif %}
-              {% endfor %}
-            </td>
+            <td id="scopeTags-{{item.id}}">{% for tag in item.tags %}{{ tag.name }}{% if not loop.last %}, {% endif %}{% endfor %}</td>
             <td style="text-align:center;">
               {% include 'admin/_scope_menu.html' %}
             </td>

From 27ec8cf4805fb968cfc27a46a8a2748c6220c1a4 Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Wed, 30 Oct 2019 22:25:31 -0700
Subject: [PATCH 3/7] Fix style violations

---
 natlas-server/app/admin/routes.py | 55 +++++++++++++++++++++----------
 1 file changed, 38 insertions(+), 17 deletions(-)

diff --git a/natlas-server/app/admin/routes.py b/natlas-server/app/admin/routes.py
index ffacdca1..577df4b4 100644
--- a/natlas-server/app/admin/routes.py
+++ b/natlas-server/app/admin/routes.py
@@ -7,7 +7,9 @@
 from app.models import User, ScopeItem, ConfigItem, NatlasServices, AgentConfig, Tag
 from app.auth.email import send_user_invite_email
 from app.auth.wrappers import isAuthenticated, isAdmin
-import ipaddress, hashlib
+import ipaddress
+import hashlib
+
 
 @bp.route('/', methods=['GET', 'POST'])
 @isAuthenticated
@@ -19,11 +21,12 @@ def admin():
 		for fieldname, fieldvalue in configForm.data.items():
 			if fieldname.upper() in ["SUBMIT", "CSRF_TOKEN"]:
 				continue
-			if fieldname.upper() == "ELASTICSEARCH_URL" and fieldvalue != current_app.config["ELASTICSEARCH_URL"]: # if we've got a new elasticsearch address, update our current handle to elastic
+			# if we've got a new elasticsearch address, update our current handle to elastic
+			if fieldname.upper() == "ELASTICSEARCH_URL" and fieldvalue != current_app.config["ELASTICSEARCH_URL"]:
 				current_app.elastic = Elastic(fieldvalue)
 			current_app.config[fieldname.upper()] = fieldvalue
 			confitem = ConfigItem.query.filter_by(name=fieldname.upper()).first()
-			confitem.value=str(fieldvalue)
+			confitem.value = str(fieldvalue)
 			db.session.add(confitem)
 		db.session.commit()
 	return render_template("admin/index.html", configForm=configForm, configItems=configItems)
@@ -102,9 +105,13 @@ def toggleUser(id):
 def scope():
 	scope = ScopeItem.getScope()
 	scopeSize = current_app.ScopeManager.getScopeSize()
-	if scopeSize == 0: # if it's zero, let's update the app's scopemanager
+
+	# if it's zero, let's make sure the ScopeManager is up to date
+	if scopeSize == 0:
 		current_app.ScopeManager.update()
-		scopeSize = current_app.ScopeManager.getScopeSize() # if it's zero again that's fine, we just had to check
+		scopeSize = current_app.ScopeManager.getScopeSize()
+	# if it's zero again that's fine, we just had to check
+
 	newForm = NewScopeForm()
 	delForm = ScopeDeleteForm()
 	editForm = ScopeToggleForm()
@@ -121,8 +128,9 @@ def scope():
 		current_app.ScopeManager.update()
 		flash('%s added!' % newTarget.target, 'success')
 		return redirect(url_for('admin.scope'))
-	return render_template("admin/scope.html", scope=scope, scopeSize=scopeSize, delForm=delForm, editForm=editForm, newForm=newForm, importForm=importForm, \
-		addTagForm=addTagForm)
+	return render_template(
+		"admin/scope.html", scope=scope, scopeSize=scopeSize, delForm=delForm,
+		editForm=editForm, newForm=newForm, importForm=importForm, addTagForm=addTagForm)
 
 
 @bp.route('/blacklist', methods=['GET', 'POST'])
@@ -147,9 +155,9 @@ def blacklist():
 		current_app.ScopeManager.update()
 		flash('%s blacklisted!' % newTarget.target, 'success')
 		return redirect(url_for('admin.blacklist'))
-	return render_template("admin/blacklist.html", scope=scope, blacklistSize=blacklistSize, delForm=delForm, editForm=editForm, \
-		newForm=newForm, importForm=importForm, addTagForm=addTagForm)
-
+	return render_template(
+		"admin/blacklist.html", scope=scope, blacklistSize=blacklistSize, delForm=delForm,
+		editForm=editForm, newForm=newForm, importForm=importForm, addTagForm=addTagForm)
 
 
 @bp.route('/import/<string:scopetype>', methods=['POST'])
@@ -192,6 +200,7 @@ def importScope(scopetype=''):
 				flash(error, 'danger')
 		return redirect(url_for('admin.%s' % scopetype))
 
+
 @bp.route('/export/<string:scopetype>', methods=['GET'])
 @isAuthenticated
 @isAdmin
@@ -205,6 +214,7 @@ def exportScope(scopetype=''):
 	items = ScopeItem.query.filter_by(blacklist=exportBlacklist).all()
 	return Response('\n'.join(str(item.target) for item in items), mimetype='text/plain')
 
+
 @bp.route('/scope/<int:id>/delete', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -244,6 +254,7 @@ def toggleScopeItem(id):
 		flash("Form couldn't validate!", 'danger')
 		return redirect(request.referrer)
 
+
 @bp.route('/scope/<int:id>/tag', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -261,6 +272,7 @@ def tagScopeItem(id):
 		flash("Form couldn't validate!", 'danger')
 		return redirect(request.referrer)
 
+
 @bp.route('/scope/<int:id>/untag', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -278,13 +290,14 @@ def untagScopeItem(id):
 		flash("Form couldn't validate!", 'danger')
 		return redirect(request.referrer)
 
+
 @bp.route('/services', methods=['GET', 'POST'])
 @isAuthenticated
 @isAdmin
 def services():
 	uploadForm = ServicesUploadForm(prefix="upload-services")
 	addServiceForm = AddServiceForm(prefix="add-service")
-	addServiceForm.serviceProtocol.choices = [("tcp", "TCP"), ("udp","UDP")]
+	addServiceForm.serviceProtocol.choices = [("tcp", "TCP"), ("udp", "UDP")]
 	if uploadForm.uploadFile.data and uploadForm.validate_on_submit():
 		newServicesContent = uploadForm.serviceFile.data.read().decode("utf-8").rstrip('\r\n')
 		newServicesSha = hashlib.sha256(newServicesContent.encode()).hexdigest()
@@ -315,8 +328,10 @@ def services():
 			flash("New service %s on port %s has been added." % (newServiceName, newServicePort), "success")
 			return redirect(url_for('admin.services'))
 
+	return render_template(
+		'admin/services.html', uploadForm=uploadForm, addServiceForm=addServiceForm,
+		current_services=current_app.current_services, servlist=current_app.current_services['as_list'])
 
-	return render_template('admin/services.html', uploadForm=uploadForm, addServiceForm=addServiceForm, current_services=current_app.current_services, servlist=current_app.current_services['as_list'])
 
 @bp.route('/services/export', methods=['GET'])
 @isAuthenticated
@@ -324,24 +339,26 @@ def services():
 def exportServices():
 	return Response(str(current_app.current_services["services"]), mimetype='text/plain')
 
+
 @bp.route('/agents', methods=['GET', 'POST'])
 @isAuthenticated
 @isAdmin
 def agentConfig():
 	agentConfig = AgentConfig.query.get(1)
-	agentForm = AgentConfigForm(obj=agentConfig) # pass the model to the form to populate
+	agentForm = AgentConfigForm(obj=agentConfig)  # pass the model to the form to populate
 	addScriptForm = AddScriptForm(prefix="add-script")
 	delScriptForm = DeleteForm(prefix="del-script")
 
 	if agentForm.validate_on_submit():
-		agentForm.populate_obj(agentConfig) # populate the object from the form data
+		agentForm.populate_obj(agentConfig)  # populate the object from the form data
 		db.session.commit()
 		current_app.agentConfig = agentConfig.as_dict()
 
-
-	return render_template('admin/agents.html', agentForm=agentForm, scripts=current_app.agentScripts, \
+	return render_template(
+		'admin/agents.html', agentForm=agentForm, scripts=current_app.agentScripts,
 		addScriptForm=addScriptForm, delScriptForm=delScriptForm)
 
+
 @bp.route('/agents/script/add', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -360,6 +377,7 @@ def addScript():
 		flash("%s couldn't be added to scripts" % addScriptForm.scriptName.data, "danger")
 		return redirect(request.referrer)
 
+
 @bp.route('/agents/script/<string:name>/delete', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -378,6 +396,7 @@ def deleteScript(name):
 			flash("%s doesn't exist" % name, "danger")
 		return redirect(request.referrer)
 
+
 @bp.route('/scans/delete/<scan_id>', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -386,7 +405,7 @@ def deleteScan(scan_id):
 
 	if delForm.validate_on_submit():
 		deleted = current_app.elastic.delete_scan(scan_id)
-		if deleted in [1,2]:
+		if deleted in [1, 2]:
 			flash("Successfully deleted scan %s." % scan_id, "success")
 			if request.referrer:
 				if scan_id in request.referrer:
@@ -403,6 +422,7 @@ def deleteScan(scan_id):
 		flash("Couldn't validate form!")
 		return redirect(request.referrer)
 
+
 @bp.route('/hosts/delete/<ip>', methods=['POST'])
 @isAuthenticated
 @isAdmin
@@ -420,6 +440,7 @@ def deleteHost(ip):
 		flash("Couldn't validate form!")
 		return redirect(request.referrer)
 
+
 @bp.route('/tags', methods=['GET', 'POST'])
 @isAuthenticated
 @isAdmin

From 1c56b207abffd864cc795ddad0c6ac6b14a58735 Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Wed, 30 Oct 2019 22:40:35 -0700
Subject: [PATCH 4/7] Reduce duplicate return statements

---
 natlas-server/app/admin/routes.py | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/natlas-server/app/admin/routes.py b/natlas-server/app/admin/routes.py
index 577df4b4..b9badb5f 100644
--- a/natlas-server/app/admin/routes.py
+++ b/natlas-server/app/admin/routes.py
@@ -193,12 +193,11 @@ def importScope(scopetype=''):
 			flash('%s targets failed to import!' % len(failedImports), 'danger')
 			for item in failedImport:
 				flash('%s' % item, 'danger')
-		return redirect(url_for('admin.%s' % scopetype))
 	else:
 		for field, errors in importForm.errors.items():
 			for error in errors:
 				flash(error, 'danger')
-		return redirect(url_for('admin.%s' % scopetype))
+	return redirect(url_for('admin.%s' % scopetype))
 
 
 @bp.route('/export/<string:scopetype>', methods=['GET'])
@@ -228,10 +227,9 @@ def deleteScopeItem(id):
 		db.session.commit()
 		current_app.ScopeManager.update()
 		flash('%s deleted!' % item.target, 'success')
-		return redirect(request.referrer)
 	else:
 		flash("Form couldn't validate!", 'danger')
-		return redirect(request.referrer)
+	return redirect(request.referrer)
 
 
 @bp.route('/scope/<int:id>/toggle', methods=['POST'])
@@ -249,10 +247,9 @@ def toggleScopeItem(id):
 			flash('%s blacklisted!' % item.target, 'success')
 		db.session.commit()
 		current_app.ScopeManager.update()
-		return redirect(request.referrer)
 	else:
 		flash("Form couldn't validate!", 'danger')
-		return redirect(request.referrer)
+	return redirect(request.referrer)
 
 
 @bp.route('/scope/<int:id>/tag', methods=['POST'])
@@ -267,10 +264,9 @@ def tagScopeItem(id):
 		scope.addTag(mytag)
 		db.session.commit()
 		flash("Tag \"%s\" added to %s" % (mytag.name, scope.target), "success")
-		return redirect(request.referrer)
 	else:
 		flash("Form couldn't validate!", 'danger')
-		return redirect(request.referrer)
+	return redirect(request.referrer)
 
 
 @bp.route('/scope/<int:id>/untag', methods=['POST'])
@@ -285,10 +281,9 @@ def untagScopeItem(id):
 		scope.delTag(mytag)
 		db.session.commit()
 		flash("Tag \"%s\" removed from %s" % (mytag.name, scope.target), "success")
-		return redirect(request.referrer)
 	else:
 		flash("Form couldn't validate!", 'danger')
-		return redirect(request.referrer)
+	return redirect(request.referrer)
 
 
 @bp.route('/services', methods=['GET', 'POST'])
@@ -307,17 +302,15 @@ def services():
 			db.session.commit()
 			current_app.current_services = NatlasServices.query.order_by(NatlasServices.id.desc()).first().as_dict()
 			flash("New services file with hash %s has been uploaded." % current_app.current_services["sha256"], "success")
-			return redirect(url_for('admin.services'))
 		else:
 			flash("That file is an exact match for our current services file!", "warning")
-			return redirect(url_for('admin.services'))
+		return redirect(url_for('admin.services'))
 
 	if addServiceForm.serviceName.data and addServiceForm.validate_on_submit():
 		newServiceName = addServiceForm.serviceName.data
 		newServicePort = str(addServiceForm.servicePort.data) + '/' + addServiceForm.serviceProtocol.data
 		if '\t' + newServicePort in str(current_app.current_services['services']):
 			flash("A service with port %s already exists!" % newServicePort, "danger")
-			return redirect(url_for('admin.services'))
 		else:
 			newServices = current_app.current_services["services"] + "\n" + newServiceName + "\t" + newServicePort
 			newSha = hashlib.sha256(newServices.encode()).hexdigest()
@@ -326,7 +319,7 @@ def services():
 			db.session.commit()
 			current_app.current_services = NatlasServices.query.order_by(NatlasServices.id.desc()).first().as_dict()
 			flash("New service %s on port %s has been added." % (newServiceName, newServicePort), "success")
-			return redirect(url_for('admin.services'))
+		return redirect(url_for('admin.services'))
 
 	return render_template(
 		'admin/services.html', uploadForm=uploadForm, addServiceForm=addServiceForm,

From 533f80c47289bffd96c81eeca2a62a269a521881 Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Thu, 31 Oct 2019 11:18:28 -0700
Subject: [PATCH 5/7] Improve tagging javascript to fix edge case behaviors

---
 natlas-server/app/static/js/natlas-tagging.js | 33 +++++++++++--------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/natlas-server/app/static/js/natlas-tagging.js b/natlas-server/app/static/js/natlas-tagging.js
index 34b01482..5ec08002 100644
--- a/natlas-server/app/static/js/natlas-tagging.js
+++ b/natlas-server/app/static/js/natlas-tagging.js
@@ -6,31 +6,38 @@ $('#tagmodal').on('show.bs.modal', function (event) {
   var tagstr = $('#scopeTags-'+scopeid).text().trim() // Trim whitespace in jinja formatting leaves whitespace
   var tags = tagstr.split(', ')
   var modal = $(this)
+  $("select[name='tagname']").val("")
   if (tagaction == 'add') {
     modal.find('.modal-title').text('Add tag to ' + scopetarget)
     modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/tag")
     modal.find('#tagScopeSubmit').text('Add Tag')
     if (tagstr != ''){
-      tags.forEach(function(item) {
-        $("option[value=" + item.trim() + "]").attr('hidden', '') // hide this option because it's already added
-        $("option[value=" + item.trim() + "]").attr('disabled', '') // disable this option because it's hidden
+      tags.forEach((item, index) => {
+        $("option[value=\"" + item.trim() + "\"]").attr({'hidden': '', 'disabled': ''}) // hide this option because it's already added
       });
     }
-
-
   } else {
     modal.find('.modal-title').text('Remove tag from ' + scopetarget)
     modal.find('#tagScopeForm').attr('action', "/admin/scope/"+scopeid+"/untag")
     modal.find('#tagScopeSubmit').text('Remove Tag')
-    $("select[name='tagname']")[0].options.length = 0;
 
-    tags.forEach(function(item) {
-      $("#tagname").append(
-        $('<option>', {
-          value: item.trim(),
-          text: item.trim()
-        })
-      );
+    // Set all options to hidden & disabled by default
+    $("select[name='tagname'] > option").each(function() {
+      $(this).attr({'hidden': '', 'disabled': ''})
+    });
+
+    // Enable options that are relevant
+    tags.forEach((item, index) => {
+      $("option[value=\"" + item.trim() + "\"]").removeAttr('hidden disabled')
     });
   }
+})
+
+$('#tagmodal').on('hide.bs.modal', function (event) {
+  var modal = $(this)
+
+  // Set all options to enabled and visible by default
+  $("select[name='tagname'] > option").each(function() {
+    $(this).removeAttr('hidden disabled')
+  });
 })
\ No newline at end of file

From e96b5eaad6c21e58df4f7e44ff84d2456bbacc9f Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Thu, 31 Oct 2019 11:22:28 -0700
Subject: [PATCH 6/7] Stop using inline comments in favor of own-line comments

---
 natlas-server/app/admin/routes.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/natlas-server/app/admin/routes.py b/natlas-server/app/admin/routes.py
index b9badb5f..ad0849c0 100644
--- a/natlas-server/app/admin/routes.py
+++ b/natlas-server/app/admin/routes.py
@@ -110,7 +110,7 @@ def scope():
 	if scopeSize == 0:
 		current_app.ScopeManager.update()
 		scopeSize = current_app.ScopeManager.getScopeSize()
-	# if it's zero again that's fine, we just had to check
+		# if it's zero again that's fine, we just had to check
 
 	newForm = NewScopeForm()
 	delForm = ScopeDeleteForm()
@@ -338,12 +338,14 @@ def exportServices():
 @isAdmin
 def agentConfig():
 	agentConfig = AgentConfig.query.get(1)
-	agentForm = AgentConfigForm(obj=agentConfig)  # pass the model to the form to populate
+	# pass the model to the form to populate
+	agentForm = AgentConfigForm(obj=agentConfig)
 	addScriptForm = AddScriptForm(prefix="add-script")
 	delScriptForm = DeleteForm(prefix="del-script")
 
 	if agentForm.validate_on_submit():
-		agentForm.populate_obj(agentConfig)  # populate the object from the form data
+		# populate the object from the form data
+		agentForm.populate_obj(agentConfig)
 		db.session.commit()
 		current_app.agentConfig = agentConfig.as_dict()
 

From 1bdce6942180cd628d225ddfcffba481f7adffdc Mon Sep 17 00:00:00 2001
From: 0xdade <0xdade@users.noreply.github.com>
Date: Thu, 31 Oct 2019 11:49:46 -0700
Subject: [PATCH 7/7] Remove unused variable

---
 natlas-server/app/static/js/natlas-tagging.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/natlas-server/app/static/js/natlas-tagging.js b/natlas-server/app/static/js/natlas-tagging.js
index 5ec08002..1593f72e 100644
--- a/natlas-server/app/static/js/natlas-tagging.js
+++ b/natlas-server/app/static/js/natlas-tagging.js
@@ -34,8 +34,6 @@ $('#tagmodal').on('show.bs.modal', function (event) {
 })
 
 $('#tagmodal').on('hide.bs.modal', function (event) {
-  var modal = $(this)
-
   // Set all options to enabled and visible by default
   $("select[name='tagname'] > option").each(function() {
     $(this).removeAttr('hidden disabled')