Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI #186

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@RustyNail
Copy link
Contributor

commented Aug 30, 2017

Add settings for to install geckodriver on TravisCI.

Add dist: trusty

@RustyNail RustyNail force-pushed the RustyNail:fix-travisci-error branch from fc59fa5 to fedf0c0 Aug 30, 2017

@mnohai-mdsol

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2017

@natritmeyer ^^

@luke-hill

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

Hi @RustyNail

At some point in the coming months I need to get more acquainted with Travis, and as such it seems as though you've got a better idea than me of how things works.

After a v2.10 cut, this is definitely near the top of my priority lists. In terms of timeframe that realistically means March at some point (Not sure when).

Sorry for the delay, and thanks again for your contribution.

Luke

@RustyNail

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2018

Hi @luke-hill

Thank you for your comment.
I'm looking forward to it.
I often use site_prism so I would like to actively contribute.

Thank you!

@luke-hill
Copy link
Collaborator

left a comment

Happy with all the changes (As the travis build was successful). I do think we will need to revisit this in a couple of months though. And I'll probably learn on you when we come to expand travis (Want to do more rubies / browsers / context)

@@ -1,5 +1,7 @@
language: ruby

dist: trusty

This comment has been minimized.

Copy link
@luke-hill

luke-hill Feb 20, 2018

Collaborator

More of a learning point for me than a review point. But this itself has only got a year or so of shelf-life. I had a quick read into the docs provided and couldn't find how to switch to Xenial (yet).

@luke-hill luke-hill added 2.10 and removed Requires Review labels Feb 20, 2018

@luke-hill luke-hill merged commit c45c171 into natritmeyer:master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@luke-hill luke-hill removed the 2.10 label Feb 20, 2018

@luke-hill

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2018

Thankyou for your PR - This has now been merged @RustyNail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.