Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] ARM64v8 Build #567

Merged
merged 2 commits into from Aug 25, 2017
Merged

[ADDED] ARM64v8 Build #567

merged 2 commits into from Aug 25, 2017

Conversation

kozlovic
Copy link
Member

Add linux/arm64 to the list of os/arch to build in the cross-compile script.

Also:

  • Drop Go 1.6.x from Travis build matrix
  • Add Go 1.9 to Travis build matrix (but exclude megacheck
    for this version since there seem to be a problem with the
    tool on Travis with that version)
  • Use Go version 1.8.3 for Docker files
  • Rename Dockerfile.win64 to Dockerfile.all to build all executables
    for which we plan to have corresponding docker images. This will
    be used in nats-docker repo.

Resolves #466

- Add linux/arm64 to cross compile script
- Update .travis.yml to push builds on Go 1.8.x version
- Update Dockerfile to Go 1.8.3
- Change Dockerfile.win64 to actually build all the builds that
  we would want to provide a Docker image for
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.527% when pulling 3179575 on add_arm_build into f2854ee on master.

Copy link
Contributor

@petemiron petemiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. go test on both ARM64 and OS X. ran cross-compile.sh and docker image build .

@kozlovic kozlovic merged commit 4246f83 into master Aug 25, 2017
@kozlovic kozlovic deleted the add_arm_build branch August 25, 2017 20:52
@kozlovic kozlovic mentioned this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants