Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using quotes around include #891

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 31, 2019

Improves the compatibility with JSON by allowing to use "include" directive within quotes.

  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Fixes #801

/cc @nats-io/core

Signed-off-by: Waldemar Quevedo wally@synadia.com

@wallyqs wallyqs force-pushed the include-parsing-fixes branch 2 times, most recently from 2cbff0d to 71ebd4a Compare January 31, 2019 16:52
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might be good to start doing very small sample files ephemerally instead of adding the to the repo.

@wallyqs
Copy link
Member Author

wallyqs commented Jan 31, 2019

@derekcollison I like that idea, ok will change into using a temp folder for the include examples to avoid more files to the repo.

@derekcollison
Copy link
Member

Thanks.

@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage decreased (-0.1%) to 91.605% when pulling 441d865 on wallyqs:include-parsing-fixes into a4741c5 on nats-io:master.

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@wallyqs
Copy link
Member Author

wallyqs commented Jan 31, 2019

Updated to use a temp folder instead for the includes.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derekcollison derekcollison merged commit 46a2661 into nats-io:master Feb 6, 2019
@wallyqs wallyqs deleted the include-parsing-fixes branch February 6, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants