-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using quotes around include #891
Conversation
2cbff0d
to
71ebd4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but might be good to start doing very small sample files ephemerally instead of adding the to the repo.
@derekcollison I like that idea, ok will change into using a temp folder for the include examples to avoid more files to the repo. |
Thanks. |
71ebd4a
to
564a8f6
Compare
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
564a8f6
to
441d865
Compare
Updated to use a temp folder instead for the includes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Improves the compatibility with JSON by allowing to use
"include"
directive within quotes.git pull --rebase origin master
)Fixes #801
/cc @nats-io/core
Signed-off-by: Waldemar Quevedo wally@synadia.com