You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation for a Subsriptions's isValid method claims to check if subscription is "active". However, looking over the source code, it appears to just check that the Subscription object was initialized with a non-null ConnectionImpl. This private conn class variable doesn't even to be set to null upon unsubscribe. As a minimum, conn should be set to null on unsubscribe. Ideally, it would check more state on the connection to ensure messages can actually make it to the subscription.
The text was updated successfully, but these errors were encountered:
We are working on a new version of the client that should resolve this issue, I am leaving the issue open for now, but if you are interested in this feature please try the new library in the version2 branch. Feedback is appreciated.
The documentation for a
Subsriptions
'sisValid
method claims to check if subscription is "active". However, looking over the source code, it appears to just check that theSubscription
object was initialized with a non-nullConnectionImpl
. This privateconn
class variable doesn't even to be set tonull
uponunsubscribe
. As a minimum,conn
should be set tonull
onunsubscribe
. Ideally, it would check more state on the connection to ensure messages can actually make it to the subscription.The text was updated successfully, but these errors were encountered: