Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined canSubscribe and canQueueSubscribe #3090

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Combined canSubscribe and canQueueSubscribe #3090

merged 1 commit into from
Apr 29, 2022

Conversation

derekcollison
Copy link
Member

Want to consistently handle canSubscribe.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor test comments.

server/accounts_test.go Outdated Show resolved Hide resolved
server/accounts_test.go Outdated Show resolved Hide resolved
…lized deny clause handling.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 806877e into main Apr 29, 2022
@derekcollison derekcollison deleted the qsub-deny branch April 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants