Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST only] A test for memory leak when creating/deleting consumers #5607

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

levb
Copy link
Contributor

@levb levb commented Jun 28, 2024

Verifies the fix in #5600

When ran locally, it was using ~180MB extra for the test before, and under 40Mb after.

(this is a replacement for #5603 that ran into some git issues.

@levb levb requested a review from a team as a code owner June 28, 2024 17:32
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 181e79d into main Jul 22, 2024
1 check passed
@derekcollison derekcollison deleted the GH-5471-leak-JS-only-replacement branch July 22, 2024 15:45
bruth added a commit that referenced this pull request Jul 30, 2024
Includes the following:

* #5602
* #5672
* #5668
* #5607
* #5687
* #5695
* #5697
* #5704
* #5706
* #5709
* #5710
* #5713
* #5719

Some PRs specifically excluded:

* #5707 — based on a 2.11 NRG
PR
* #5690 — continue to allow
Go 1.20 for 2.10.x
* Various other NRG PRs which are higher risk and destined for 2.11
instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants