[FIXED] Subscription interest could remain after slow consumer error #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a slow consumer error is detected, the server will close the connection. In some race situations, it could be that the subscription interest is left intact, which would cause routed servers to continue routing messages although the interest should have been gone. The subscription could still be seen in the monitoring subscriptions list (when displaying with details), referencing a client connection that would be in the closed connection state. The monitoring route page of the other servers would still indicate that there is interest for this subject on the origin server. Resolves #5539 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
This avoids the alloc and copy and still allows the connection to be properly released. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
| @@ -5511,6 +5513,14 @@ func (c *client) closeConnection(reason ClosedState) { | |||
| } | |||
| } | |||
|
|
|||
| // Now that we are done with subscriptions, clear the field so that the | |||
| // connection can be released and gc'ed. | |||
| if kind == CLIENT || kind == LEAF { | |||
There was a problem hiding this comment.
FYI when we set this to nil in saveClosedClient it was a much broader set of connection types. Do we think this might cause any GC issues on non client/leaf connections?
There was a problem hiding this comment.
No because we invoked saveClosedClient() only for CLIENT and LEAF:
Line 1828 in 02bd284
There was a problem hiding this comment.
Sorry was just looking at the internal if..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a slow consumer error is detected, the server will close the connection. In some race situations, it could be that the subscription interest is left intact, which would cause routed servers to continue routing messages although the interest should have been gone.
The subscription could still be seen in the monitoring subscriptions list (when displaying with details), referencing a client connection that would be in the closed connection state.
The monitoring route page of the other servers would still indicate that there is interest for this subject on the origin server.
Resolves #5539
Signed-off-by: Ivan Kozlovic ivan@synadia.com