From c507edd9bd586f6526dd6f1a6ddb3593728ba4fe Mon Sep 17 00:00:00 2001
From: Alberto Ricart <alberto@synadia.com>
Date: Tue, 18 Jun 2024 08:30:11 -0500
Subject: [PATCH] [FIX] [JS] [KV] - fixed an issue where the default
 `maxBucketSize` of `-1` (a deprecated option) overrode a specified
 `max_bytes`.

Fixes #706
---
 jetstream/kv.ts            |  2 +-
 jetstream/tests/kv_test.ts | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/jetstream/kv.ts b/jetstream/kv.ts
index 6b535554..65e9cecd 100644
--- a/jetstream/kv.ts
+++ b/jetstream/kv.ts
@@ -108,7 +108,7 @@ export function defaultBucketOpts(): Partial<KvOptions> {
     replicas: 1,
     history: 1,
     timeout: 2000,
-    maxBucketSize: -1,
+    max_bytes: -1,
     maxValueSize: -1,
     codec: NoopKvCodecs(),
     storage: StorageType.File,
diff --git a/jetstream/tests/kv_test.ts b/jetstream/tests/kv_test.ts
index 1d655e60..795357f2 100644
--- a/jetstream/tests/kv_test.ts
+++ b/jetstream/tests/kv_test.ts
@@ -2164,3 +2164,14 @@ Deno.test("kv - watcher on server restart", async () => {
   await d;
   await cleanup(ns, nc);
 });
+
+Deno.test("kv - maxBucketSize doesn't override max_bytes", async () => {
+  let { ns, nc } = await setup(
+    jetstreamServerConf({}),
+  );
+  const js = nc.jetstream();
+  const kv = await js.views.kv("A", { max_bytes: 100 });
+  const info = await kv.status();
+  assertEquals(info.max_bytes, 100);
+  await cleanup(ns, nc);
+});