From 5c4567f723f60150b9a80744003d1f83e2b76e31 Mon Sep 17 00:00:00 2001 From: Piotr Piotrowski Date: Thu, 15 Sep 2022 10:15:17 +0200 Subject: [PATCH] Get rid of compatibility check in create / update consumer --- jserrors.go | 3 --- jsm.go | 6 ------ 2 files changed, 9 deletions(-) diff --git a/jserrors.go b/jserrors.go index 65761738e..a97344c0c 100644 --- a/jserrors.go +++ b/jserrors.go @@ -98,9 +98,6 @@ var ( // ErrCantAckIfConsumerAckNone is returned when attempting to ack a message for consumer with AckNone policy set. ErrCantAckIfConsumerAckNone JetStreamError = &jsError{message: "cannot acknowledge a message for a consumer with AckNone policy"} - // ErrRequireServerVersion is returned when using a feature which requires a higher server version. - ErrRequireServerVersion JetStreamError = &jsError{message: "invalid server version"} - // DEPRECATED: ErrInvalidDurableName is no longer returned and will be removed in future releases. // Use ErrInvalidConsumerName instead. ErrInvalidDurableName = errors.New("nats: invalid durable name") diff --git a/jsm.go b/jsm.go index f42d148d8..da7eae726 100644 --- a/jsm.go +++ b/jsm.go @@ -262,9 +262,6 @@ func (js *js) AddConsumer(stream string, cfg *ConsumerConfig, opts ...JSOpt) (*C if cfg == nil { cfg = &ConsumerConfig{} } - if cfg.Name != _EMPTY_ && !js.nc.serverMinVersion(2, 9, 0) { - return nil, fmt.Errorf("%w: %s", ErrRequireServerVersion, "consumer name requires at least server version 2.9.0") - } consumerName := cfg.Name if consumerName == _EMPTY_ { consumerName = cfg.Durable @@ -290,9 +287,6 @@ func (js *js) UpdateConsumer(stream string, cfg *ConsumerConfig, opts ...JSOpt) if cfg == nil { return nil, ErrConsumerConfigRequired } - if cfg.Name != _EMPTY_ && !js.nc.serverMinVersion(2, 9, 0) { - return nil, fmt.Errorf("%w: %s", ErrRequireServerVersion, "consumer name requires at least server version 2.9.0") - } consumerName := cfg.Name if consumerName == _EMPTY_ { consumerName = cfg.Durable