V2.1.0 #174
Merged
V2.1.0 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
August 15, 2018 14:23
Subscriptions and Dispatchers can drain. Connections can drain. Added several tests for main and exceptional cases. Fixed #170
Only upload snapshot from oracle jdk 8.
Updated dependency for NKey to implementation
Added support for drain in message queue Added callback after unsub/flush to mark message queue Improved flush timeout behavior Added timeout to drain if unsub/flush times out Added several tests for drain and flush Removed support for R/R during drain Converted natsbench to throttling - it was failing More doc
fixed wrong exception from get private key
…gs on reconnect. This is hard to test but likely happens when pings are sent during a slower reconnect. Added a check for the null pointer. Added a check to not ping the server if not connected (in the ping timer). Fixes #172
Updated readme Fixed issue in travis Updated changelog
| * messages have reached the server. | ||
| * Finally the connection is closed. | ||
| * | ||
| * In order to drain subscribers, an unsub is sent to the server followed by a flush. |
Member
There was a problem hiding this comment.
Nitpick. Maybe say UNSUB protocol message?
| * were drained in the timeout, and false otherwise. The future is completed after the connection | ||
| * is closed, so any connection handler notifications will happen before the future completes. | ||
| * | ||
| * @param timeout The time to wait for the drain to succeed, pass 0 to wait |
Member
There was a problem hiding this comment.
In other languages we use -1 for "forever".
Contributor
Author
There was a problem hiding this comment.
since we don't support 0 time, i think this is ok. Also, changing would require a major revision bump.
| try { | ||
| reply = incoming.get(timeout.toNanos(), TimeUnit.NANOSECONDS); | ||
| } catch (ExecutionException|TimeoutException e) { | ||
| } catch (ExecutionException | TimeoutException e) { |
Member
There was a problem hiding this comment.
Did you intend to leave interrupted and cancellation exceptions uncaught?
Contributor
Author
There was a problem hiding this comment.
yes, interrupted exceptions should rarely be eaten as they tell the caller the thread was interrupted. Cancellation has the same meaning here for the future, so we don't want to eat it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Drain on the connection and Subscription.
Fixed a null pointer in certain situations with ping/reconnect
Added more JDKs to travis build
Bumping version number for added drain API.