From 8f580e36e1b7bd0c6f0613d9111dc958ec65748c Mon Sep 17 00:00:00 2001
From: Alberto Ricart <alberto@synadia.com>
Date: Tue, 2 Nov 2021 15:21:54 -0500
Subject: [PATCH] nbc handling of request exception rejecting rather than
 throwing (#119)

- [UPDATE] nbc to 1.3.1
- [FIX] undid a fix on a test that hid an actual issue where the request, which returns a promise was also throwing - on deno this doesn't happen and the promise is rejected properly - on node because the function is not async, it actually does throw instead of rejecting the request.
---
 package-lock.json       | 4 ++--
 package.json            | 2 +-
 src/connect.ts          | 2 +-
 src/mod.ts              | 2 +-
 src/nats-base-client.ts | 2 +-
 src/ws_transport.ts     | 6 +++---
 test/basics.js          | 8 +++-----
 7 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 4c58109..253d154 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "nats.ws",
-  "version": "1.3.1-2",
+  "version": "1.4.1",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "nats.ws",
-      "version": "1.3.1-2",
+      "version": "1.4.1",
       "license": "Apache-2.0",
       "devDependencies": {
         "@types/node": "^16.10.3",
diff --git a/package.json b/package.json
index 7056e30..cdb9bf1 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nats.ws",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "WebSocket NATS client",
   "main": "nats.cjs",
   "module": "nats.js",
diff --git a/src/connect.ts b/src/connect.ts
index 905245c..9846239 100644
--- a/src/connect.ts
+++ b/src/connect.ts
@@ -19,7 +19,7 @@ import {
   setTransportFactory,
   Transport,
   TransportFactory,
-} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.0/nats-base-client/internal_mod.ts";
+} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.1/nats-base-client/internal_mod.ts";
 
 import { WsTransport } from "./ws_transport.ts";
 
diff --git a/src/mod.ts b/src/mod.ts
index e21b106..468ed8e 100644
--- a/src/mod.ts
+++ b/src/mod.ts
@@ -12,5 +12,5 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-export * from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.0/nats-base-client/mod.ts";
+export * from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.1/nats-base-client/mod.ts";
 export { connect } from "./connect.ts";
diff --git a/src/nats-base-client.ts b/src/nats-base-client.ts
index f2974ad..401f228 100644
--- a/src/nats-base-client.ts
+++ b/src/nats-base-client.ts
@@ -13,4 +13,4 @@
  * limitations under the License.
  */
 // this import here to drive the build system
-export * from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.0/nats-base-client/internal_mod.ts";
+export * from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.1/nats-base-client/internal_mod.ts";
diff --git a/src/ws_transport.ts b/src/ws_transport.ts
index d5910f3..a40fa0f 100644
--- a/src/ws_transport.ts
+++ b/src/ws_transport.ts
@@ -19,7 +19,7 @@ import type {
   Server,
   ServerInfo,
   Transport,
-} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.0/nats-base-client/internal_mod.ts";
+} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.1/nats-base-client/internal_mod.ts";
 import {
   checkOptions,
   DataBuffer,
@@ -30,9 +30,9 @@ import {
   INFO,
   NatsError,
   render,
-} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.0/nats-base-client/internal_mod.ts";
+} from "https://raw.githubusercontent.com/nats-io/nats.deno/v1.3.1/nats-base-client/internal_mod.ts";
 
-const VERSION = "1.4.0";
+const VERSION = "1.4.1";
 const LANG = "nats.ws";
 
 export class WsTransport implements Transport {
diff --git a/test/basics.js b/test/basics.js
index fe80b7b..7634eaa 100644
--- a/test/basics.js
+++ b/test/basics.js
@@ -614,11 +614,9 @@ test("basics - subject is required", async (t) => {
     nc.publish();
   }, { code: ErrorCode.BadSubject });
 
-  try {
-    await nc.request();
-  } catch (err) {
-    t.is(err.message, "BAD_SUBJECT");
-  }
+  await nc.request().catch((err) => {
+    t.is(err.code, ErrorCode.BadSubject);
+  });
 
   await nc.close();
   await ns.stop();