Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read.neurons should set names to match neuron$NeuronName #383

Closed
jefferis opened this issue Jan 9, 2019 · 1 comment
Closed

read.neurons should set names to match neuron$NeuronName #383

jefferis opened this issue Jan 9, 2019 · 1 comment
Assignees
@jefferis
Labels
breaking
Milestone
1.9

Comments

@jefferis
Copy link
Collaborator

jefferis commented Jan 9, 2019

... i.e. the filename without its extension.
@jefferis jefferis self-assigned this Jan 9, 2019
@jefferis jefferis added this to the 1.9 milestone Jan 9, 2019
@jefferis
Copy link
Collaborator Author

jefferis commented Jan 9, 2019

This may break some scripts but I think it is cleaner to chop off the file extensions. In theory we could take the name directly from each neuron$NeuronName, but there might perhaps be cases where this is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jefferis jefferis

Labels
breaking
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
1 participant
@jefferis