…mera This issue was occurring after (1) adding a markup and (2) registering a custom Slicer layout having at least on Slice view. It addresses the following warning: WorldToView: no active camera, cannot compute world to view, returning 0,0,0 The "no active camera" warning/issue is also discussed in Slicer issue #1690 but note that this commit does NOT address that problem.
This approach is more robust and doesn't really on the system processor name.
This commit fixes the warnings like the following: // ---------------------- 1>-- Configuring Loadable module: Transforms [qSlicerTransformsModuleExport.h] 1>CMake Warning (dev) at C:/D/P/SonoEQ-0-build/Slicer-build/CTK/CMake/ctkMacroBuildQtPlugin.cmake:168 (get_target_property): 1> Policy CMP0026 is not set: Disallow use of the LOCATION target property. 1> Run "cmake --help-policy CMP0026" for policy details. Use the cmake_policy 1> command to set the policy and suppress this warning. 1> The LOCATION property should not be read from target 1> "qSlicerAnnotationsModuleWidgetsPlugins". Use the target name directly 1> with add_custom_command, or use the generator expression $<TARGET_FILE>, as 1> appropriate. 1>Call Stack (most recent call first): 1> C:/D/P/SonoEQ-0-build/Slicer-build/CTK/CMake/ctkMacroBuildQtPlugin.cmake:181 (ctkMacroBuildQtPlugin) 1> Modules/Loadable/Annotations/Widgets/DesignerPlugins/CMakeLists.txt:36 (ctkMacroBuildQtDesignerPlugin) // ----------------------
Tweak test in ExternalProject_Message to avoid warning related to CMP0054 This commit will avoid warning like this one: //-------------------- CMake Warning (dev) at CMake/ctkMacroCheckExternalProjectDependency.cmake:345 (if): Policy CMP0054 is not set: Only interpret if() arguments as variables or keywords when unquoted. Run "cmake --help-policy CMP0054" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Quoted variables like "SB_SECOND_PASS" will no longer be dereferenced when the policy is set to NEW. Since the policy is not set the OLD behavior will be used. Call Stack (most recent call first): CMake/ctkMacroCheckExternalProjectDependency.cmake:596 (ExternalProject_Message) CMakeExternals/Log4Qt.cmake:9 (ExternalProject_Include_Dependencies) CMake/ctkMacroCheckExternalProjectDependency.cmake:568 (include) CMake/ctkMacroCheckExternalProjectDependency.cmake:614 (ExternalProject_Include_Dependencies) CMake/ctkBlockCheckDependencies.cmake:132 (ExternalProject_Include_Dependencies) CMakeLists.txt:970 (include) //--------------------
…ont mess up doc generation
* 478-use-cmake-prefix-path-instead-of-qt5-install-prefix: Removed custom QT5_INSTALL_PREFIX variable.
In some of the header files in the plugin framework, the two macros Q_DECLARE_PRIVATE(ctkPlugin) Q_DISABLE_COPY(ctkPlugin) appeared at the beginning of the class declaration. This is valid c++, but the doxygen generator intrepret this as a private statement and thus all subsequent public method declarations are interpreted as private, thus hiding them from the user documentation. We have no idea why doxygen does this. Investigation was done in cooperation with @jcfr. Fix: Moved the offending macros to the end of the class declaration.
…not happen that the dcmtk libraries are installed to some unintended location. Setting dcmtk_dir to dcmtk-build directory
* fix-vtk6-python-disabled-build-error: Ensure CTKVisualizationVTKWidget build with VTK6 and python disabled.
When there are two strings with the only difference that one is longer (e.g., "Label Statistics" and "Label Statistics (BRAINS)") then one of them is missing from the search results. The problem was that QAbstractItemModel::match was used for checking if the string is already in the model and by default Match uses Qt::MatchStartsWith option. Fixed by using Qt::MatchFixedString.