HTTPS clone URL
Subversion checkout URL
History for CTK/Libs
Commits on Oct 8, 2015
The test is run but only used to see if vtkRenderingFreeTypeFontConfig is to be linked, but it is already tested whether the vtk target vtkRenderingFreeTypeFontConfig actually exists. In addition on Debian the FontConficConfig.cmake file doesn't extist, so the test fails and linking as well, because the needed vtkRenderingFreeTypeFontConfig is not added to the linker line.
Commits on Oct 7, 2015
The patch adds the Qt5::Widgets include path and Qt5::Test libraries where it is appropritate.
Commits on Oct 6, 2015
Commits on Sep 15, 2015
Add to the browser Remove button the information that it will delete all selected series, studies, patients. Add support for right click custom context menus in the patient, study, series tables. Translate the local points to global ones in terms of the table view and signal right clicked with the global position so that the browser can position the context menu appropriately. Add the context menu to the DICOM browser to allow deleting at just one level, with number of items selected information, and a confirmation message box with descriptive information that can be set to not be shown again. Added a test for the DICOM browser, with the ability to open it in interactive mode to test the right clicks. Add query wrappers for the DICOM database to get the patient name as well as descriptions for series and study. They will return empty strings on failure. Use the new queries to give more meaningful information on the right click pop up menu in the DICOM browser. Added a test for the new DICOM database accessors. Slicer bug: http://www.na-mic.org/Bug/view.php?id=3792 When Slicer makes a custom DICOM browser, it moves the table views directly into the new window, extracting them from the DICOM table. With this change, the table view takes care of mapping the point to global, the table manager propagates the signal as a table specific XRightClicked signal, and the browser responds to it with a table specific context menu. Slicer Issue #3792
Commits on Sep 11, 2015
…inalizing the Python interpreter This commit reverts 77a24f2. The original change worked in conjunction with fixes in PythonQt to avoid various crashes while destroying the ctkAbstractPythonManager, for example by calling Py_DECREF after the Python interpreter was finalized. Further testing shows that a better fix is indeed to finalize first to ensure clean destruction of PythonQt objects, and to make PythonQt's clean up step more robust by handling a finalized interpreter. An example of code which necessitates this change is creating an instance of class Foo: class Foo(object): def __init__(self): self.timer = qt.QTimer() def __del__(self): self.timer.setSingleShot(True) During Py_Finalize(), the Foo instance's __del__ method is called, which in turn calls a method on a Qt object. For this to succeed, PythonQt's data must still be in place.
Commits on Sep 3, 2015
…hon interpreter This commit moves the call to PythonQt's cleanup function to be before the call that finalizes the Python interpreter. The interpreter should still be running during PythonQt::cleanup() so that calls to Py_DECREF succeed.
Commits on Aug 31, 2015
Commits on Aug 21, 2015
Commits on Aug 18, 2015
Commits on Aug 17, 2015
Andras Lasso authored
1. ctkVTKDataSetArrayComboBox caused application crash when it is used for a VTK data set that is generated by a pipeline and the combobox was used for setting active scalar. When a data set is changed due to a pipeline change, the data set is first reset and then recomputed. During reset the scalars are removed therefore the selection in the combobox is changed to item (-1), which triggers a data update. During update all the scalars are removed (again, so there is no change) but then the scalars are re-added when the data is recomputed. Qt combobox automatically selects the first item if an item is added, therefore the selection changes to the first active scalar. This change triggers a data set update, which starts with a reset. During reste the scalars are removed, therefore the selection in the combobox is changed to item (-1), which triggers a data update... This is an infinite loop, which causes application crash due to stack overflow. Solution was to add a NULL item (no active scalar). This is also useful because without a NULL item it is not possible to unselect scalars. For backward compatibility reasons, by default NULL item is not added (it is not needed if the combobox is not used for setting the active scalar). 2. ctkVTKDataSetArrayComboBox did not contain any arrays that were added after the data set and attribute types are added. vtkDataSet Modified event is not invoked if arrays are added/removed/renamed, only vtkDataSet.PointData and vtkDataset.CellData object Modified events are invoked. ctkVTKDataSetModel did not observe the point and cell data objects. Solution was to add observers to the point and cell data objects.
Commits on Aug 10, 2015
This change was inspired by using a ctkMessageBox with three options and wanting to be clear what would happen if the don't show again option was used. Add the text from the button with the accept role to the text string so that the user knows what will happen by default if they chose not to show this message box again.
Commits on Jul 22, 2015
…th-kits' * fix-visualization-vtk-core-linking-against-vtk-build-with-kits: Tweak logic specifying libraries to link against VisualizationVTKCore
Since vtkRenderingFreeTypeOpenGL2 does not exist and vtkRenderingFreeTypeOpenGL, the suffix OpenGL is hardcoded. Also move the logic in the FontConfig block. Worth noting that vtkRenderingFreeTypeOpenGL has been removed in version > 6.2.0 (See Kitware/VTK@4f7460a)
…th-kits' * fix-visualization-vtk-core-linking-against-vtk-build-with-kits: Fix link error when linking against VTK build with KITS enabled.
This commit fixes the error report below happening when building against VTK configured with option VTK_ENABLE_KITS enabled. The explicit list of VTK libraries has been originally added in 4c54ae0 (Make VTK6 linking more robust) to fix issue when building CTK on Debian (see Debian bug #747436) 8<---8<---8<---8<---8<---8<--- [...] Linking CXX shared library ../../../../bin/libCTKVisualizationVTKCore.so /usr/bin/ld: cannot find -lvtkRenderingFreeTypeOpenGL collect2: error: ld returned 1 exit status [...] 8<---8<---8<---8<---8<---8<---
Commits on Jul 21, 2015
Commits on Jul 16, 2015
…leted This commit fixes the following error reported by valgrind memcheck tool by using a QScopedPointer. ==29339== 304 (136 direct, 168 indirect) bytes in 1 blocks are definitely lost in loss record 2,065 of 2,448 ==29339== at 0x4C2B0E0: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29339== by 0x20AECCE1: QObject::QObject(QObject*) (in /home/jcfr/Support/qt-everywhere-opensource-release-build-4.8.6/lib/libQtCore.so.4.8.6) ==29339== by 0x88008D8: ctkDoubleSpinBoxPrivate::ctkDoubleSpinBoxPrivate(ctkDoubleSpinBox&) (ctkDoubleSpinBox.cpp:174) ==29339== by 0x880271F: ctkDoubleSpinBox::ctkDoubleSpinBox(QWidget*) (ctkDoubleSpinBox.cpp:587) ==29339== by 0x887AB25: Ui_ctkSliderWidget::setupUi(QWidget*) (ui_ctkSliderWidget.h:50) ==29339== by 0x8877D13: ctkSliderWidget::ctkSliderWidget(QWidget*) (ctkSliderWidget.cpp:175) ==29339== by 0x5E99878: Ui_qMRMLSliceControllerWidget::setupUi(ctkPopupWidget*) (ui_qMRMLSliceControllerWidget.h:391) ==29339== by 0x5E8BA8A: qMRMLSliceControllerWidgetPrivate::setupPopupUi() (qMRMLSliceControllerWidget.cxx:128) ==29339== by 0x5EC28C0: qMRMLViewControllerBarPrivate::init() (qMRMLViewControllerBar.cxx:98) ==29339== by 0x5E8CB69: qMRMLSliceControllerWidgetPrivate::init() (qMRMLSliceControllerWidget.cxx:328) ==29339== by 0x5E923BB: qMRMLSliceControllerWidget::qMRMLSliceControllerWidget(QWidget*) (qMRMLSliceControllerWidget.cxx:1237) ==29339== by 0x5EA70F0: Ui_qMRMLSliceWidget::setupUi(qMRMLWidget*) (ui_qMRMLSliceWidget.h:43)
Commits on Jul 15, 2015
Commits on Jul 14, 2015
Commits on Jul 3, 2015
Commits on Jun 30, 2015
Commits on Jun 29, 2015
Commits on Jun 26, 2015
Button icon has no color if setColor is called with invalid QColor.
Commits on Jun 24, 2015