Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: master
Commits on Jun 24, 2015
  1. ENH: remove unused Resolution setting on ruler node

    naucoin authored
    Remove the Resolution setting as it's only used inside
    the node, it has been superceded by the tick settings.
    
    
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24357 3bd1e089-480b-0410-8dfb-8563597acbee
  2. ENH: add utility method to display node in only 1 view

    naucoin authored
    Since the view node id logic is set up to be backward compatible (no view node
    id set means showing in all views), provide a convenience function,
    SetDisplayableOnlyInView, that reduces this operation to one call.
    It places the calls to remove all view node ids and add the new one inside of
    a disable modified events block to avoid flicker.
    Added testing.
    
    Issue #3196
    
    
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24356 3bd1e089-480b-0410-8dfb-8563597acbee
  3. @jcfr

    ENH: Update transforms module to support copy/paste of linear transfo…

    jcfr authored
    …rms.
    
    This commit improve the transforms module to allow user to copy/paste
    linear transforms to/from the clipboard. Matrix of size 2x2, 3x3 or
    4x4 are supported.
    
    Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    
    Fixes #4010
    
    From: Adam Rankin <adam.rankin@gmail.com>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24355 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Jun 23, 2015
  1. @jcfr

    STYLE: Remove unused ivar from qSlicerSubjectHierarchyModuleWidget

    jcfr authored
    The "ModuleWindowInitialized" ivar has been introduced as part of
    commit r23235 (ENH: Subject hierarchy module added) and is not used
    anywhere.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24354 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Jun 22, 2015
  1. @jcfr

    ENH: Expose SH plugin "setDisplayVisibility()" method to python

    jcfr authored
    This commit will allow scripted module to update the visibility
    associated with a given SubjectHierarchy node doing the following:
    
     shNode = [...]
     shPluginHandler = slicer.qSlicerSubjectHierarchyPluginHandler.instance()
     shPlugin = shPluginHandler.getOwnerPluginForSubjectHierarchyNode(shNode)
     shPlugin.setDisplayVisibility(shNode, visible)
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24353 3bd1e089-480b-0410-8dfb-8563597acbee
  2. BUG: expand null pointer checking

    naucoin authored
    Extend ResampleVolumeToReferenceVolume to check that input and
    reference volumes have transforms defined before trying to use
    them.
    
    
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24352 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Jun 19, 2015
  1. @jcfr

    ENH: Improve CLI image widget type handling

    jcfr authored
    * show both LabelMap and scalar volume nodes if "scalar" type
    is specified (to restore behavior before vtkMRMLLabelMapVolumeNode
    was added)
    
    * allow adding either vtkMRMLScalarVolumeNode or vtkMRMLLabelMapVolumeNode
    if "scalar" type is specified
    
    * allow adding of multiple output node types if "any" type is specified
    as output
    
    Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    
    From: Andras Lasso <lasso@queensu.ca>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24351 3bd1e089-480b-0410-8dfb-8563597acbee
  2. @jcfr

    ENH: Multiple node types can be created in qMRMLNodeComboBox

    jcfr authored
    Now any of the supported node types can be created in a qMRMLNodeComboBox
    - as it was available in Slicer3 and requested for Slicer4.
    
    Note also that the combo box special entry "Create and Rename new <node>"
    has been changed into "Create new <node> as...".
    
    Fixes http://www.na-mic.org/Bug/view.php?id=3748
    
    Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
    
    From: Andras Lasso <lasso@queensu.ca>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24350 3bd1e089-480b-0410-8dfb-8563597acbee
  3. @jcfr

    BUG: sitkUtils: Add 'LabelMap' to list of volume types supported by S…

    jcfr authored
    …impleITK
    
    This commit fixes support for vtkMRMLLabelMapVolumeNode added
    in r24291 (ENH: Use vtkMRMLLabelMapVolumeNode class for labelmap volumes)
    
    Fixes #4004
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24349 3bd1e089-480b-0410-8dfb-8563597acbee
  4. @jcfr

    BUG: Update BRAINSTools to fix loading of bspline transform

    jcfr authored
    Note that the corresponding change has also been submitted as
    a pull request in the official BRAINSTools repo.
    See BRAINSia/BRAINSTools#194
    
    // -------------
    Author: Andras Lasso <lasso@queensu.ca>
    Date:   Fri Jun 19 15:33:03 2015 -0400
    
        BUG: Fixed loading of bspline transform
    
        The transformFileType and typename were inconsistent.
    // -------------
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24348 3bd1e089-480b-0410-8dfb-8563597acbee
  5. @jcfr

    STYLE: Remove unused import statement from util.py

    jcfr authored
    This commit removes an unused import statement introduced in r24320 (STYLE:
     Editor-helperBox: Add "getNodeByName()" to slicer.util and rename it)
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24347 3bd1e089-480b-0410-8dfb-8563597acbee
  6. @jcfr

    STYLE: Update volume info widget to track volume node using a weak po…

    jcfr authored
    …inter
    
    Use a weak pointer to make sure no dangling pointers are accidentally used.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24346 3bd1e089-480b-0410-8dfb-8563597acbee
  7. @jcfr

    BUG: Remove duplicate connection to node selector in Volumes module w…

    jcfr authored
    …idget
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24345 3bd1e089-480b-0410-8dfb-8563597acbee
  8. BUG: 3857. Fixed parallel/perpendicular diffusivity on glyphs, intera…

    alexy authored
    …ctive seeding line display.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24344 3bd1e089-480b-0410-8dfb-8563597acbee
  9. @jcfr

    BUG: String containing list of dependencies was not split. Fixes #4007

    jcfr authored
    If one was creating an extension that depended on multiple other
    extensions and was giving, as specified in the s4ext files, a list of
    extensions separated by spaces, Slicer did not split that list when
    looking for dependencies upon download, and was trying to find an
    extension with all the names.
    
    e.g. If your s4ext file contained the following line:
    
       depends     DTIProcess ResampleDTIlogEuclidean
    
    Slicer was trying to resolve the dependencies and was trying
    to find the extension named "DTIProcess ResampleDTIlogEuclidean",
    instead of finding both extensions separately.
    
    From: Francois Budin <fbudin@email.unc.edu>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24343 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Jun 18, 2015
  1. BUG: expand null pointer checking

    naucoin authored
    Add a test for null image data in input and output images
    in ResampleVolumeToReferenceVolume since it is not checked
    before access in the method. 
    
    
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24342 3bd1e089-480b-0410-8dfb-8563597acbee
  2. STYLE: Removed remnants of non-existent qMRMLNodeSelector class

    lassoan authored
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24341 3bd1e089-480b-0410-8dfb-8563597acbee
  3. ENH: Added warning if obsolete LabelMap flag used in node selector

    lassoan authored
    If the obsolete LabelMap attribute is used in qMRMLNodeComboBox then the attribute is ignored and a warning is logged.
    This way modules that are not yet updated to use vtkMRMLLabelMapVolumeNode will still work reasonably well.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24340 3bd1e089-480b-0410-8dfb-8563597acbee
Commits on Jun 17, 2015
  1. @jcfr

    BUG: Ensure effect FastGrowCut can use EditorLib.LabelEffectLogic

    jcfr authored
    This commit fixes the following error:
    
    //-----------
    File "/home/jcfr/.config/NA-MIC/Extensions-24309/FastGrowCutEffect/lib/Slicer-4.4/qt-scripted-modules/FastGrowCutEffect.py", line 10, in <module>
      from EditorLib import LabelEffectLogic
    ImportError: cannot import name LabelEffectLogic
    //-----------
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24339 3bd1e089-480b-0410-8dfb-8563597acbee
  2. @jcfr

    ENH: Backwards compatible FixedParameters

    jcfr authored
    This patch provides alternatives for both
    defining the m_FixedParameters of a transfor
    as either the old-style ParametersType or
    preferably the new-style FixedParametersType
    when it is available in ITK.
    
    Prepare for post ITK4.8 TransformFix
    
    This patch makes Slicer prepared for future changes to
    ITK that can not be backwards compatible.
    
    http://review.source.kitware.com/#/c/19921/
    
    From: Hans Johnson <hans-johnson@uiowa.edu>
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24338 3bd1e089-480b-0410-8dfb-8563597acbee
  3. @jcfr

    BUG: EditorLib: Avoid circular dependency and optimize effect imports

    jcfr authored
    This commit has two roles:
    
    (1) do not import "EditorLib" from module themselve imported in
    "EditorLib/__init__.py"
    
    (2) update effects to specify the __all__ attribute, this will
    ensure only the expected objects are imported when calling
    "from NameEffect import *" and will avoid clobbering the caller scope.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24337 3bd1e089-480b-0410-8dfb-8563597acbee
  4. @jcfr

    STYLE: Editor-Effect: Simplify updateMRMLFromGUI using NodeModify con…

    jcfr authored
    …text
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24336 3bd1e089-480b-0410-8dfb-8563597acbee
  5. @jcfr
  6. @jcfr
  7. @jcfr

    BUG: Editor-helpBox: Maintain backward compatibility for structures w…

    jcfr authored
    …idget
    
    This commit fixes PCampReview@b3d3d29 extension
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24333 3bd1e089-480b-0410-8dfb-8563597acbee
  8. @jcfr

    STYLE: Editor-helperBox: Refactor code adding LabelStructureListWidget

    jcfr authored
    This commit move all functionality specific to "per-structure" management
    into a reusable widget named "LabelStructureListWidget"
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24332 3bd1e089-480b-0410-8dfb-8563597acbee
  9. @jcfr

    STYLE: Editor-helperBox: Refactor and simplify code using VTKObservat…

    jcfr authored
    …ionMixin
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24331 3bd1e089-480b-0410-8dfb-8563597acbee
  10. @jcfr

    STYLE: Editor-helperBox: Refactor code adding "EditUtil.setActiveVolu…

    jcfr authored
    …mes()"
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24330 3bd1e089-480b-0410-8dfb-8563597acbee
  11. @jcfr

    STYLE: Editor-helperBox: Remove extraneous "applicationLogic" ivar

    jcfr authored
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24329 3bd1e089-480b-0410-8dfb-8563597acbee
  12. @jcfr

    STYLE: Update Editor effects and tests to directly use EditUtil

    jcfr authored
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24328 3bd1e089-480b-0410-8dfb-8563597acbee
  13. @jcfr

    STYLE: Editor-editUtil: Change EditUtil class method to be static

    jcfr authored
    This simplifies the code avoiding to explicitly instantiate the EditUtil
    class.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24327 3bd1e089-480b-0410-8dfb-8563597acbee
  14. @jcfr

    ENH: Editor-helperBox: Simplify UI using node selector for merge volume

    jcfr authored
    This commit uses a node selector to (1) display the current merge volume
    name, (2) allow the user to select a different one and (3) create a new
    one if needed.
    
    By using a node selector, it simplifies the code by:
     * removing the need for the "mergeName" HelperBox ivar
     * removing the need for the "merge" HelperBox ivar and instead add a property
     * removing the obsolete LabelSelectDialog dialog
    
    Note that a custom "Create new " action is associated.
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24326 3bd1e089-480b-0410-8dfb-8563597acbee
  15. @jcfr

    STYLE: Editor-helperBox: Rename ivar "mergeFrame" to "mergeSelectorFr…

    jcfr authored
    …ame"
    
    Both "master" and "merge" frames are now consistently named
    
    git-svn-id: http://svn.slicer.org/Slicer4/trunk@24325 3bd1e089-480b-0410-8dfb-8563597acbee
  16. @jcfr
  17. @jcfr
Something went wrong with that request. Please try again.