Li-Hsuan Lung naush

@naush
naush merged pull request naush/ReviewNinja-Welcome#1
@naush
Review this to get started
1 commit with 40 additions and 1 deletion
@naush
Test
@naush
Test
naush opened pull request naush/ReviewNinja-Welcome#1
@naush
Review this to get started
1 commit with 40 additions and 1 deletion
@naush
naush created repository naush/ReviewNinja-Welcome
naush commented on pull request namely/countries#6
@naush

+1

naush commented on pull request namely/connect#41
@naush

@cored If we are starting from scratch here, I would actually put it under app/services or the like. Because to me app/**/ designates the type of o…

naush commented on pull request namely/connect#41
@naush

Dangerous thoughts! :smirk_cat:

naush commented on pull request namely/connect#41
@naush

@cored Thanks for sharing the conversation here! Given a established presentation layer, I would always choose to move my presentation logic there …

naush commented on pull request namely/connect#41
@naush

@cored I like explicit require, too! Clearer separation of concerns. You have to be totally commit to do it right though. Managing file loading ord…

naush commented on pull request namely/connect#41
@naush

Wait, I keep confusing this project with namely. Well, I guess you can make the decision of if you want to keep following the same pattern as we do…

naush commented on pull request namely/connect#41
@naush

Given that all of our current plain ruby business domain objects live under app/lib right now, it does seem jarring to me to place connect/ on the …

naush commented on pull request namely/connect#41
@naush

I am fine with explicit require if we decide to keep /connect out of autoloading path and we want to manage file loading order ourselves, but I wou…

naush commented on pull request namely/connect#41
@naush

I see it is being used in more than one spot, which makes for a good argument for method extraction. However, I would make two suggestions. 1. The …

naush pushed to master at naush/essays
@naush
  • @naush ed7d24c
    Create craftsmen-painters-and-monks.md
naush pushed to master at naush/essays
@naush
  • @naush 19482f7
    Create in-search-of-diversity.md
naush pushed to master at naush/essays
@naush
  • @naush d36e4fc
    Update craftsmanship-and-innovation.md
naush pushed to master at naush/essays
@naush
naush pushed to master at naush/essays
@naush
naush pushed to master at naush/essays
@naush
naush pushed to master at naush/essays
@naush
  • @naush 7fdd187
    Rename craftsmanship and innovation
naush pushed to master at naush/essays
@naush
  • @naush 1be7806
    First draft of craftsmanship and innovation
naush created branch master at naush/essays
naush created repository naush/essays
naush commented on pull request danningge/tictactoe#2
naush commented on pull request danningge/tictactoe#2
@naush

I would add an extra whitespace after +=. Ie, @count += 1