Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO users should not be able to try to change their password #1503

Closed
lampwins opened this issue Mar 15, 2022 · 1 comment · Fixed by #1696
Closed

SSO users should not be able to try to change their password #1503

lampwins opened this issue Mar 15, 2022 · 1 comment · Fixed by #1696
Assignees
Labels
type: bug Something isn't working as expected

Comments

@lampwins
Copy link
Member

Environment

  • Python version: 3.8
  • Nautobot version: 1.2.8

Steps to Reproduce

  1. Enable SSO automatication
  2. Login as an SSO user
  3. Navigate to your user profile

Expected Behavior

Because I am an SSO user, I should not be presented with the ability to change my password.

Observed Behavior

The change password view is accessible and I am able to attempt a password change. This operation of course fails because no password is actually set for my user account.

@bryanculver bryanculver added type: bug Something isn't working as expected workflow: ready for prioritization labels Mar 15, 2022
@jathanism
Copy link
Contributor

jathanism commented Mar 15, 2022

Looks like we'd need to update the conditional that decides whether or not that nav tab is exposed. Today it's only gated on {% if not request.user.ldap_username %}, which would only be relevant for LDAP backends.

@glennmatthews glennmatthews changed the title SSO users should not be able to change their password SSO users should not be able to try to change their password Apr 5, 2022
@briddo briddo self-assigned this Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants