Turns off staking in cfund-proposal-state-accept.py and other cfund tests (#376)

* adds assert after try blocks and checks for preq creation during new state

* fixes update of PENDING_VOTING_PREQ state

* adds test to check accepted preq stay accepted

* assigns cycle number variable based on cfundstats

* adds print statements to debug in travis

* adds staking(false) to all cfund tests, also comments out print statements

* removes print statments

Author: marcus290

qa/rpc-tests/cfund-listproposals.py

@@ -25,9 +25,8 @@ def run_test(self):
         # Get cfund parameters
         blocks_per_voting_cycle = self.nodes[0].cfundstats()["consensus"]["blocksPerVotingCycle"]
 
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
-
-        # Donate to fund
         self.nodes[0].donatefund(100)
 
         # Create proposals

qa/rpc-tests/cfund-paymentrequest-state-accept.py

@@ -21,6 +21,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
         self.nodes[0].donatefund(100)
 

qa/rpc-tests/cfund-paymentrequest-state-expired.py

@@ -22,10 +22,8 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
-        # Make sure cfund is active
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
-
-        # Donate to the cfund
         self.nodes[0].donatefund(10)
 
         # Create a proposal

qa/rpc-tests/cfund-paymentrequestvotelist.py

@@ -21,7 +21,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
-        # Make sure cfund is active
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
         self.nodes[0].donatefund(1000)
 

qa/rpc-tests/cfund-proposal-state-accept.py

@@ -21,6 +21,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
 
         proposal_duration = 3

qa/rpc-tests/cfund-proposal-state-expired.py

@@ -21,6 +21,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
 
         # Create proposal

qa/rpc-tests/cfund-proposalvotelist.py

@@ -21,7 +21,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
-        # Make sure cfund is active
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
         self.nodes[0].donatefund(1000)
 

qa/rpc-tests/cfund-rawtx-create-proposal.py

@@ -30,6 +30,7 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
 
         # creates a good proposal and sets things we use later
@@ -120,7 +121,7 @@ def test_invalid_proposal(self, address, amount, duration, description):
         callSucceed = False
         try:
             proposal = self.send_raw_proposalrequest(address, amount, duration, description)
-            print(proposal)
+            #print(proposal)
             callSucceed = True
         except :
             pass
@@ -146,8 +147,8 @@ def test_valid_description(self, descriptionTxt, proposal_list_len):
         propHash = ""
         callSucceed = True
 
-        print("Test Description: -------------------------")
-        print(descriptionTxt)
+        #print("Test Description: -------------------------")
+        #print(descriptionTxt)
         try:
             propHash = self.send_raw_proposalrequest(self.goodAddress, self.goodAmount, self.goodDuration, descriptionTxt)
             #print(propHash)

qa/rpc-tests/cfund-rawtx-paymentrequest-create.py

@@ -28,10 +28,8 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
-        # Make sure cfund is active
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
-
-        # Donate to the cfund
         self.nodes[0].donatefund(100)
 
         # Get address

qa/rpc-tests/cfund-rawtx-paymentrequest-vote.py

@@ -20,10 +20,8 @@ def setup_network(self, split=False):
         self.is_network_split = split
 
     def run_test(self):
-        # Make sure cfund is active
+        self.nodes[0].staking(False)
         activate_cfund(self.nodes[0])
-
-        # Donate to the cfund
         self.nodes[0].donatefund(100)
 
         # Get address