Fix crash with -banversion (#432)

alex v · web-flow · commit a25b1391120b · 2019-03-22T00:01:00.000+01:00
Fixes the range of the for loop which was causing a client crash when using the -banversion argument.
diff --git a/src/main.cpp b/src/main.cpp
@@ -6653,7 +6653,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,
             std::vector<std::string> vBannedVersions = mapMultiArgs["-banversion"];
             bool fBanned = false;
 
-            for (unsigned int i = 0; i <= vBannedVersions.size(); i++)
+            for (unsigned int i = 0; i < vBannedVersions.size(); i++)
             {
                 if(vBannedVersions[i] == pfrom->cleanSubVer)
                 {

Original file line number	Diff line number	Diff line change
`@@ -6653,7 +6653,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,`
`6653`	`6653`	`std::vector<std::string> vBannedVersions = mapMultiArgs["-banversion"];`
`6654`	`6654`	`bool fBanned = false;`
`6655`	`6655`
`6656`		`- for (unsigned int i = 0; i <= vBannedVersions.size(); i++)`
	`6656`	`+ for (unsigned int i = 0; i < vBannedVersions.size(); i++)`
`6657`	`6657`	`{`
`6658`	`6658`	`if(vBannedVersions[i] == pfrom->cleanSubVer)`
`6659`	`6659`	`{`