Fix fixed stake reward check - #369
Merged
Merged
Conversation
The stake reward, even if fixed, includes the fees of the transactions included in the block. The removed check does not take the fees making the network reject all the blocks which include a transaction. At this point, the total amount of fees is still unknown. This is safely removed as the check is properly done in line 3322.
aguycalled
requested review from
marcus290,
matt-auckland and
proletesseract
December 14, 2018 20:40
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 14, 2018
- Bumps version to v4.5.1 - Sets a fork height at 2722100 - Requires blocks to signal version bit 21 when fork happens. Merge after navcoin#367 navcoin#369 and navcoin#370 or when its related issues are fixed.
Merged
Member
|
im building and checking this now. going to write a couple more python tests to make sure its covered also. |
Member
|
@aguycalled do we want to write a test that tries to construct a block which has an incorrect stake amount and test whether it is accepted on the network, or are we confident this is covered correctly by line 3322? |
remove print
Member
Author
|
Line 3322 covers correctly the check, but we need general tests for our whole POS implementation, there's none currently. |
proletesseract
approved these changes
Dec 15, 2018
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
- Bumps version to v4.5.1 - Sets a fork height at 2722100 - Requires blocks to signal version bit 21 when fork happens. Merge after navcoin#367 navcoin#369 and navcoin#370 or when its related issues are fixed.
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
* Fix fixed stake reward check The stake reward, even if fixed, includes the fees of the transactions included in the block. The removed check does not take the fees making the network reject all the blocks which include a transaction. At this point, the total amount of fees is still unknown. This is safely removed as the check is properly done in line 3322. * test tx sends after soft fork * file permission fix * adding blockcount param * corrected object calling rpc command * remove print
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stake reward, even if fixed, includes the fees of the transactions included in the block.
The removed check does not take the fees making the network reject all the blocks which include a transaction. At this point of the function, the total amount of fees is still unknown.
This is safely removed as the check is properly done in line 3322.