Fixes Payment Request payout when Proposal is expired - #370
Merged
proletesseract merged 15 commits intoDec 17, 2018
Conversation
Adds a new state for proposals (PENDING_VOTING_PREQ). This transitory state will be asigned to expired proposals with payment requests pending being voted. Once a expired proposal runs out of pending payment requests, the proposal will move to EXPIRED state. Payment Requests voting can only start while the state of the parent Proposal is ACCEPTED. Payouts to Payment Requests are only authorized when a Proposal is in ACCEPTED or PENDING_VOTING_PREQ state. Includes RPC test.
aguycalled
requested review from
matt-auckland,
proletesseract and
red010b37
December 14, 2018 22:33
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 14, 2018
- Bumps version to v4.5.1 - Sets a fork height at 2722100 - Requires blocks to signal version bit 21 when fork happens. Merge after navcoin#367 navcoin#369 and navcoin#370 or when its related issues are fixed.
Merged
Member
|
I'm checking this out and testing it |
…guycalled/navcoin-core into fix-pr-payout-expired-proposal
#47) * adds assert after try blocks and checks for preq creation during new state * fixes update of PENDING_VOTING_PREQ state
marcus290
approved these changes
Dec 16, 2018
marcus290
left a comment
marcus290
left a comment
Contributor
There was a problem hiding this comment.
I tested the bug manually and with the new tests and this patch fixes it.
I added one more test here:
aguycalled#48
* adds assert after try blocks and checks for preq creation during new state * fixes update of PENDING_VOTING_PREQ state * adds test to check accepted preq stay accepted * assigns cycle number variable based on cfundstats
proletesseract
approved these changes
Dec 17, 2018
matt-auckland
approved these changes
Dec 17, 2018
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
- Bumps version to v4.5.1 - Sets a fork height at 2722100 - Requires blocks to signal version bit 21 when fork happens. Merge after navcoin#367 navcoin#369 and navcoin#370 or when its related issues are fixed.
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
…proposal Fixes Payment Request payout when Proposal is expired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new state for proposals (PENDING_VOTING_PREQ). This transitory state
will be asigned to expired proposals with payment requests pending being
voted. Once a expired proposal runs out of pending payment requests,
the proposal will move to EXPIRED state.
Payment Requests voting can only start while the state of the parent Proposal
is ACCEPTED.
Payouts to Payment Requests are only authorized when a Proposal is in
ACCEPTED or PENDING_VOTING_PREQ state.
Includes RPC test.