RPC paymentrequestvotelist and proposalvotelist change#380
Merged
Conversation
Member
aguycalled
commented
Dec 17, 2018
aguycalled
commented
- Change output to show JSON instead of string
added 4 commits
December 17, 2018 23:58
- Change output to show JSON instead of string
Member
|
Looks good, will approve after testing |
marcus290
approved these changes
Dec 18, 2018
Contributor
marcus290
left a comment
marcus290
left a comment
There was a problem hiding this comment.
manually tested and checked rpc tests
matt-auckland
approved these changes
Dec 18, 2018
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
* RPC paymentrequestvotelist and proposalvotelist change - Change output to show JSON instead of string * Update proposalvotelist test * Update paymentrequestvotelist test * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.