fixes #388: cache cfund votes and add bench log#390
Merged
Conversation
Contributor
|
@aguycalled @matt-auckland I'm getting a mismatch between the no. of votes shown with The sync is much faster indeed. |
Member
Author
|
good catch. committed f1154b4 |
Member
|
The sync speed is good. I'm getting through a few hundred blocks per second or more. @marcus290 I'll leave it to you to confirm if you're happy with the fix for the votes stats. |
Member
Author
|
can we merge this? |
proletesseract
approved these changes
Jan 10, 2019
aguycalled
pushed a commit
to skreener/navcoin-core
that referenced
this pull request
Feb 3, 2019
fixes navcoin#388: cache cfund votes and add bench log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #388.
Keeps a cache of the community fund votes to avoid an unnecessary recalculation per block which was causing extreme slow synchronization in the order of 0,25-0,3s per block.
After applying the patch the CountVotes() function takes an average of 32ms.