Mnemonic support #400
Merged
Mnemonic support #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguycalled
requested review from
red010b37,
proletesseract,
ro-savage,
matt-auckland and
marcus290
|
cACK, will test this when I have spare time |
| } | ||
|
|
||
|
|
||
| //long_hash decode_mnemonic(const word_list& mnemonic, |
There was a problem hiding this comment.
Is there a reason we need to leave this code in?
| @@ -150,13 +150,13 @@ NavCoinGUI::NavCoinGUI(const PlatformStyle *platformStyle, const NetworkStyle *n | |||
| prevBlocks(0), | |||
| spinnerFrame(0), | |||
| fDontShowAgain(false), | |||
| lastDialogShown(0), | |||
| unlockWalletAction(0), | |||
| lockWalletAction(0), | |||
| toggleStakingAction(0), | |||
| @@ -25,7 +25,6 @@ NavTechInit::~NavTechInit() | |||
| void NavTechInit::ShowNavtechIntro(bool exitAfter) | |||
| { | |||
| NavTechInit navtechinit; | |||
|
@matt-auckland going to evaluate functionality and report back |
|
I manually tested Just wondering, why not add support for the remaining languages that are already in dictionary.cpp? I also think 8051262 maybe should be moved out to a separate commit. |
marcus290
approved these changes
Feb 22, 2019
This reverts commit 1bdd883.
matt-auckland
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new RPC command to export the existing master private key encoded as a mnemonic:
dumpmnemonic
It admits an argument specifying the language.
Support for two new wallet options (-importmnemonic and -mnemoniclanguage) have also been added to allow to create a new wallet from the specified mnemonic.
Testing needed.