Mnemonic support#400
Conversation
aguycalled
requested review from
marcus290,
matt-auckland,
proletesseract,
red010b37 and
ro-savage
|
cACK, will test this when I have spare time |
| } | ||
|
|
||
|
|
||
| //long_hash decode_mnemonic(const word_list& mnemonic, |
There was a problem hiding this comment.
Is there a reason we need to leave this code in?
| lastDialogShown(0), | ||
| unlockWalletAction(0), | ||
| lockWalletAction(0), | ||
| toggleStakingAction(0), |
| @@ -25,7 +25,6 @@ NavTechInit::~NavTechInit() | |||
| void NavTechInit::ShowNavtechIntro(bool exitAfter) | |||
| { | |||
| NavTechInit navtechinit; | |||
|
@matt-auckland going to evaluate functionality and report back |
|
I manually tested Just wondering, why not add support for the remaining languages that are already in dictionary.cpp? I also think 8051262 maybe should be moved out to a separate commit. |
This reverts commit 1bdd883.
matt-auckland
left a comment
matt-auckland
left a comment
There was a problem hiding this comment.
I tested with English and Japanese.
Seems to work fine ✅
I checked if it would fail if I mixed languages ✅
I checked if it would fail if I used an incorrect spelling in the mnemonic ✅
I checked if it would work if I used the wrong number of words ✅
5 participants
This PR adds a new RPC command to export the existing master private key encoded as a mnemonic:
dumpmnemonic
It admits an argument specifying the language.
Support for two new wallet options (-importmnemonic and -mnemoniclanguage) have also been added to allow to create a new wallet from the specified mnemonic.
Testing needed.