Fixed rpc tests#405
Merged
Merged
Conversation
changed to slowgen
Modified generates and changed values to account for different maturity of blocks
changed to slowgen and changed block generation values
changed to slowgen and formatted exception handling
Porting fixed RPC tests
Fixed rpc tests
Port RPC tests
marcus290
approved these changes
Jan 29, 2019
Contributor
marcus290
left a comment
marcus290
left a comment
There was a problem hiding this comment.
I've tested locally and all the revised tests pass
matt-auckland
requested review from
aguycalled,
matt-auckland,
proletesseract and
red010b37
Contributor
|
To summarise, all uncommented tests in It seems that using |
aguycalled
approved these changes
Feb 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed certain rpc-tests from Issue #358.
This pull-request contains a branch based off of the branch
update-rpc-testsfrom my original pull request here. We decided that it would be safer and easier to cherry-pick the working rpc-tests from theupdate-rpc-testsbranch and to manually copy them over to thefixed-rpc-testsbranch rather than attempt to resolve the old pull-request.