v452 Hard Fork #413
Merged
v452 Hard Fork #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update master
WIP test for duplicate cfund payout amount, address, etc
added second node and tried to break it a few more ways
…in-core into fix-preq-payout
reduced sleep
commenting out some of the test to find where travis is failling
stripped back to one test
removed debug flag
only running the nodes setup
not connecting the nodes together
trying with clean chain option
updating to master
452 hardfork
added version bit comment
trying to replicate same situation as the block which failed.
test which replicates known conditions of the duplicate payout block
Fix preq payout
updated blockheight, added activation check
Adds test for double preq payout before and after fork
marcus290
approved these changes
Feb 7, 2019
Contributor
marcus290
left a comment
marcus290
left a comment
There was a problem hiding this comment.
Currently one test (wallet.py) failed randomly in Travis for one build but not the other. I don't think it's related to this PR and I have recorded it in a separate issue #416
Rerunning Travis would likely result in a pass
updated blockheight to 2900000
update fork block height to 2882875
matt-auckland
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated versioning to 4.5.2
Enforce version bit 21 for all blocks after 2882875.
The RPC test has also been made more generic so you just pass in the version bit and activation height rather than needing a function for each version bit.
Need to write a test to cover the functionality which checks if height has been reached when rejecting blocks with invalid CFund payment requests.