Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC tests: fixes merkle_blocks.py to exclude 1st coinbase #423

Merged
merged 2 commits into from
Feb 24, 2019

Conversation

marcus290
Copy link
Contributor

Fixes one of the tests in #416.

merkle_blocks.py fails randomly on Travis (see https://travis-ci.org/NAVCoin/navcoin-core/jobs/493122877) due to "absurdly-high-fee" error here:

        node0utxos = self.nodes[0].listunspent(1)
        tx1 = self.nodes[0].createrawtransaction([node0utxos.pop()], {self.nodes[1].getnewaddress(): 49.99})
        txid1 = self.nodes[0].sendrawtransaction(self.nodes[0].signrawtransaction(tx1)["hex"])

node0utxos is a list of 55 unspent coinbase outputs from generating 55 blocks in the test environment, which are mostly 50 NAV each. However, the first coinbase is 59,800,000 NAV and if this is popped from the list, it will cause a fee error.

Setting maximum confirmations to listunspent() will avoid the 1st coinbase.

Co-Authored-By: marcus290 <36244342+marcus290@users.noreply.github.com>
@marcus290 marcus290 merged commit 52ed487 into navcoin:master Feb 24, 2019
@marcus290 marcus290 deleted the fix-merkle-blocks-py branch February 27, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants