Skip to content

fix cold staking report#425

Merged
aguycalled merged 3 commits into
navcoin:masterfrom
aguycalled:origin/cold-staking-report
Feb 26, 2019
Merged

fix cold staking report#425
aguycalled merged 3 commits into
navcoin:masterfrom
aguycalled:origin/cold-staking-report

Conversation

@aguycalled

Copy link
Copy Markdown
Member

This PR fixes a bug where the cold staking coins were not correctly accounted in the output of the RPC command getstakereport or the report shown on the GUI Main tab.

@matt-auckland matt-auckland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK

@marcus290

Copy link
Copy Markdown
Contributor

@aguycalled On regtest, I'm getting the wrong display amount for coldstakes because pcoin->GetCredit(ISMINE_SPENDABLE_STAKABLE) is returning zero. Do you get the same thing?
stakereportgui

@aguycalled

Copy link
Copy Markdown
Member Author

committed 5b7a3b3

@marcus290 marcus290 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested on regtest. works for me

@aguycalled
aguycalled merged commit 765d5be into navcoin:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants