-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Wallet Community Fund UI Improvement #428
Conversation
hdnsimpson
commented
Feb 27, 2019
•
edited
Loading
edited
- Added a Community Fund tab to the core wallet
- Ability to view and filter proposals and payment request
- Proposals and payment requests can be voted on and created
- Removed the old Community Fund UI
…d duration dialog with resize on page
… into communityfund
…on support and removed more headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've manually tested the UI on regtest for viewing proposals/payment requests in different states, changes in vote numbers and states. I've also checked the display of current proposals/payment requests on mainnet. Looks good to me!
For createproposal / createpaymentrequest UI, I can also confirm there are the same checks as the rpc commands.
I gave some feedback but these have already been addressed in some of the commits after 2ecfdcf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im only part way through - will finish the rest later, all super minor and more code hygiene than anything major
everything looks quite good from what i've tested in devnet. i only miss a filter for seeing proposals/prequests in pending state for which I haven't voted yet. this should be the view I see when I click the open community fund button from the new proposals alert dialog. |