This PR is a combined fix for issues #445 and #446#450
Merged
Conversation
Member
|
utACK |
aguycalled
requested changes
Apr 30, 2019
mxaddict
force-pushed
the
master
branch
9 times, most recently
from
May 1, 2019 00:33
d178be9 to
4d5863c
Compare
Contributor
Author
|
@aguycalled , The changes in the branch now should be final, can you give it another look? |
aguycalled
approved these changes
May 1, 2019
proletesseract
approved these changes
May 1, 2019
proletesseract
left a comment
Member
There was a problem hiding this comment.
All modified unit tests make sense and are passing, wallet compiles and runs.
proletesseract
added a commit
to proletesseract/navcoin-core
that referenced
this pull request
May 2, 2019
merging master to get PR's navcoin#450 and navcoin#459
This was referenced May 2, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that PR#447 did not fix the issue entirely, but it did point to the right direction.
This PR has changes that fix both #445 and #446
The fix in PR #447 Fixed the balance in the wallet with only "spending" address, but caused the same bug to appear on the wallet with only "staking" address
This PR fixes the issue on 3 wallet scenarios :
Both the transactions list and the stakereport show the correct values based on my testing