Build: Compatibility with boost 1.67 #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boost apparently requires these operators to be callable on const values since version 1.59.0.
native() has been deprecated in favor of native_handle() since version 1.47 and was finally removed in version 1.66.
|
tested correctly built osx&debian |
aguycalled
approved these changes
May 6, 2019
|
Compiling against |
I built this PR against |
mxaddict
approved these changes
May 6, 2019
Test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building navcoin-core with boost-1.67 out of the box.
Though I tested this against boost 1.67, the branch fixes build problems from 1.59 onwards, which affect users of at least Debian 9 (Stretch) and newer and probably other modern distributions. So I think the problems fixed should affect enough users to justify these relatively simple changes.