[OSX] macdeployqtplus bug fixes [OSX]

[sherlockcoin]

Background image of the OSX install window is mis-sized #379

[aguycalled]

@sherlockcoin would it be possible to automate the version which appears on the background? otherwise i think i would rather remove it and leave just NAVCOIN CORE

[sherlockcoin]

Sure! it is possible, just wanted to make sure people knew the right version when downloading the DMG.

[mxaddict]

utACK

[mxaddict]

I think these changes will require testing with gitian build

[sherlockcoin]

tACK
QT GUI compiled and tested on OS X 10.12.6 (Sierra) - Non-deterministic.

[aguycalled]

gitian fails

+ make osx_volname
echo NavCoin-Core >osx_volname
+ make deploydir
sed 's/PACKAGE_NAME/NavCoin Core/' < "contrib/macdeploy/background.svg" |  -f png -d 36 -p 36 | /usr/bin/convert - dpi36.background.tiff
/bin/bash: -f: command not found
convert: no decode delegate for this image format `' @ error/constitute.c/ReadImage/504.
convert: no images defined `dpi36.background.tiff' @ error/convert.c/ConvertImageCommand/3258.
make: *** [dpi36.background.tiff] Error 1
Makefile:1195: recipe for target 'dpi36.background.tiff' failed

[sherlockcoin]

Can you tell me the gitian system and dependencies please? Looks like an imagemagick error.

[sherlockcoin]

Found it! :) One moment.

[sherlockcoin]

@aguycalled is it possible to verify if its an imagemagick issue? Would it possible to reinstall imagemagick and re-test?

[aguycalled]

you can do it yourself, gitian is a deterministic build system we use, hence its importance the binaries can build there. it should be patched on this pr if its needed. https://github.com/navcoin/navcoin-core/blob/master/doc/gitian-building.md Von meinem iPhone gesendet

…

Am 07.06.2019 um 13:29 schrieb sherlockcoin ***@***.***>: @aguycalled is it possible to verify if its an imagemagick issue? Would it possible to reinstall imagemagick and re-test? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[sherlockcoin]

Indeed. I will do the needful. 👍

[sherlockcoin]

Gitian Build success. :)

[mxaddict]

testedACK

I've compiled and tested on Ubuntu 18.04 (Just for sanity check)

I can't test on OSX myself.

[sherlockcoin]

@mxaddict Thank you mate. It was quite a fix lol. 😄

[mxaddict]

@sherlockcoin the DMG looks nice and professional! Nice work! 👍

[sherlockcoin]

@sherlockcoin the DMG looks nice and professional! Nice work! 👍

Thank you mate. <3 Cheers! :)

[mxaddict]

BTW, I'm doing a gitian build for OSX now, and will ask @lordhace to check my build, will post results here 🥇

[sherlockcoin]

Can @aguycalled and everyone review and merge this? :)

[lordhace]

BTW, I'm doing a gitian build for OSX now, and will ask @lordhace to check my build, will post results here 🥇

Works on OSX 10.13.6

[aguycalled]

Tested

[mxaddict]

Nice!

[sherlockcoin]

Awesome! :)