Updated ./src/univalue from upstream #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
what does this upgrade bring new? |
Contributor
Author
Mainly upstream changes from https://github.com/jgarzik/univalue And upstream changes from https://github.com/bitcoin-core/univalue/pulls?q=is%3Apr+is%3Aclosed The changes from jgarzik are more maintenance related (Some code cleanup + bug fixes) The bitcoin-core changes seem to be for keeping the code working with the bitcoin-core wallet. |
Member
|
building on ubuntu 18.04 now |
Contributor
Author
|
BTW, I think in the future we can have univalue and seck code be git subtrees and have lint step on travis check if it's updated from upstream repos I'll make an issue so we don't forget. |
proletesseract
approved these changes
Jun 16, 2019
Member
proletesseract
left a comment
proletesseract
left a comment
There was a problem hiding this comment.
builds and runs on ubuntu 18.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.