Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new progress ui for sync #526

Merged
merged 3 commits into from
Jun 16, 2019
Merged

Added new progress ui for sync #526

merged 3 commits into from
Jun 16, 2019

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jun 12, 2019 •
edited
Loading

closes #385

@mxaddict mxaddict requested review from hdnsimpson, proletesseract and aguycalled and removed request for hdnsimpson and proletesseract June 12, 2019 22:48
@mxaddict
Copy link
Contributor Author

Screenshot from 2019-06-13 06-51-15

@mxaddict
Copy link
Contributor Author

@aguycalled Looks like the header counter is not working properly (Seems to load correct header count on load, but while syncing it shows block count instead of header count), I will fix that in the next push.

@mxaddict
Copy link
Contributor Author

Header counter now updated to use pindexBestHeader

@mxaddict
Copy link
Contributor Author

output

@mxaddict
Copy link
Contributor Author

mxaddict commented Jun 13, 2019 •
edited
Loading

Travis build passed, I've also tested a full sync, took about 12 hours but UI showed correct functionality 👍

EDIT: On Ubuntu 18.04

@aguycalled
Copy link
Member

Tested in OSX, working perfectly

@mxaddict
Copy link
Contributor Author

@aguycalled I remember wanting this feature like 6 months ago (Having seen it in DGB wallet)

I never thought I would be coding it into NAV myself! 🤣

@proletesseract
Copy link
Member

Builds and runs on ubuntu 18.04. Works as expected.

@proletesseract proletesseract merged commit 42769b2 into navcoin:master Jun 16, 2019
@aguycalled
Copy link
Member

Paid 8e023b42fb899433938309b69b3fa71829cdd465ef9a8880eeeee8a1a85909f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proletesseract proletesseract proletesseract approved these changes

@aguycalled aguycalled aguycalled approved these changes

@hdnsimpson hdnsimpson Awaiting requested review from hdnsimpson

Assignees
No one assigned
Labels
bounty paid bounty-high ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI improve for core wallet - blockchain syncing (Video Demo)
3 participants
@mxaddict @aguycalled @proletesseract