Added new progress ui for sync - #526
Merged
Merged
Conversation
mxaddict
requested review from
aguycalled,
hdnsimpson and
proletesseract
and removed request for
hdnsimpson and
proletesseract
June 12, 2019 22:48
Contributor
Author
|
|
Contributor
Author
|
@aguycalled Looks like the header counter is not working properly (Seems to load correct header count on load, but while syncing it shows block count instead of header count), I will fix that in the next push. |
Contributor
Author
|
Header counter now updated to use |
Contributor
Author
|
|
Contributor
Author
|
Travis build passed, I've also tested a full sync, took about 12 hours but UI showed correct functionality 👍 EDIT: On Ubuntu 18.04 |
Member
|
Tested in OSX, working perfectly |
aguycalled
approved these changes
Jun 13, 2019
Contributor
Author
|
@aguycalled I remember wanting this feature like 6 months ago (Having seen it in DGB wallet) I never thought I would be coding it into NAV myself! 🤣 |
Member
|
Builds and runs on ubuntu 18.04. Works as expected. |
proletesseract
approved these changes
Jun 16, 2019
Member
|
Paid 8e023b42fb899433938309b69b3fa71829cdd465ef9a8880eeeee8a1a85909f1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #385