Skip to content

Check node address in header spam protection#536

Merged
proletesseract merged 1 commit intonavcoin:masterfrom
aguycalled:header-spam
Jun 29, 2019
Merged

Check node address in header spam protection#536
proletesseract merged 1 commit intonavcoin:masterfrom
aguycalled:header-spam

Conversation

@aguycalled
Copy link
Copy Markdown
Member

Taken from QTUM fix qtumproject/qtum#703

Copy link
Copy Markdown
Contributor

@mxaddict mxaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, testsuite passed locally (Ubuntu 18.04)

Not sure how to test a DOS attack on this change though

@proletesseract
Copy link
Copy Markdown
Member

compiles and runs on Ubuntu 18.04. Syncing works. Code changes make sense. I haven't tested spamming headers manually. Is it worth trying to write a unit test to cover this spam protection?

@proletesseract proletesseract merged commit 45c98d5 into navcoin:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants