Revert nBits patch#544
Merged
Merged
Conversation
mxaddict
reviewed
Jun 30, 2019
mxaddict
left a comment
mxaddict
left a comment
Contributor
There was a problem hiding this comment.
utACK,
compiling and testing now 👍
Contributor
|
This PR now syncs from block 0 with no errors from nBit check Currently my test node it @ block ~150k Will post back when fully synced |
Member
|
building now, will report back soon. |
proletesseract
added a commit
to proletesseract/navcoin-core
that referenced
this pull request
Jun 30, 2019
release notes done apart from navcoin#544 when it gets merged.
mxaddict
approved these changes
Jun 30, 2019
Contributor
|
Tested with a full sync with all index flags enabled and completed successfully |
proletesseract
approved these changes
Jun 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #517 as it introduced a bug which prevented the wallet to sync from scratch and the DoS attack vector which it tried to fix is already covered by the Header Spam protection filter.